Skip to content

Tests: Use unregister_taxonomy() in Tests_Admin_IncludesScreen - #15447

Open
devmuhib009 wants to merge 1 commit into
WordPress:trunkfrom
devmuhib009:tests/65893-clean-up-includes-screen
Open

devmuhib009 wants to merge 1 commit into
WordPress:trunkfrom
devmuhib009:tests/65893-clean-up-includes-screen

Conversation

@devmuhib009

Copy link
Copy Markdown
Member

Uses unregister_taxonomy() instead of manually unsetting the global registry in Tests_Admin_IncludesScreen::tear_down().

Trac ticket: https://core.trac.wordpress.org/ticket/65893

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props devmuhib.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues with the test teardown change to use WordPress’s taxonomy cleanup API.

No open issues 🎉

What changed in this PR

Updates Tests_Admin_IncludesScreen teardown to use WordPress’s taxonomy cleanup API instead of directly modifying the global registry.

Changes:

  • Replaces manual removal of old-or-new with unregister_taxonomy( 'old-or-new' ).
File Description
tests/​phpunit/​tests/​admin/​includesScreen.php Uses unregister_taxonomy() for taxonomy cleanup in tear_down().

Review effort: Balanced

@huzaifaalmesbah huzaifaalmesbah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devmuhib009!

Properly replaces manual global unsetting with core unregister_taxonomy() in Tests_Admin_IncludesScreen::tear_down(). Verified random order execution. Looks good to me!

AI Review: Gemini 3.8 Flash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants