Skip to content

Tests: Clean up custom post type in Tests_Post_wpListPages - #15453

Open
devmuhib009 wants to merge 1 commit into
WordPress:trunkfrom
devmuhib009:test/cleanup-cpt-wp-list-pages
Open

devmuhib009 wants to merge 1 commit into
WordPress:trunkfrom
devmuhib009:test/cleanup-cpt-wp-list-pages

Conversation

@devmuhib009

Copy link
Copy Markdown
Member

Trac ticket: https://core.trac.wordpress.org/ticket/65893

This PR unregisters the taco custom post type registered during Tests_Post_wpListPages::test_wp_list_pages_classes_with_hierarchical_cpt() in tear_down() using the public unregister_post_type() function, preventing fixture leakage and replacing the internal mid-test call.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props devmuhib.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@huzaifaalmesbah huzaifaalmesbah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devmuhib009!

Properly unregisters the taco custom post type in tear_down() and removes the mid-test unregistration call in Tests_Post_wpListPages, preventing fixture leakage across tests. Looks good to me!

AI Review: Gemini 3.8 Flash

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the change moving custom post type cleanup into test teardown.

No open issues 🎉

What changed in this PR

This PR improves fixture cleanup in Tests_Post_wpListPages by moving custom post type removal into the test teardown lifecycle.

Changes:

  • Adds tear_down() to unregister taco using the public unregister_post_type() API before calling the parent teardown.
  • Removes the internal mid-test cleanup call so cleanup still runs if an assertion fails.
File Description
tests/​phpunit/​tests/​post/​wpListPages.php Moves custom post type cleanup into teardown and uses the public API.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants