[devmuhib009]

Trac ticket: https://core.trac.wordpress.org/ticket/65893

This PR unregisters custom post types foo, bar, and baz in tear_down() using the public unregister_post_type() function in Tests_Post_GetPostsByAuthorSql, preventing fixture leakage across tests and removing internal mid-test unregistration calls.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props devmuhib.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

---

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

• @propsbot add <username> to give props to a GitHub user. Requires write access.
• @propsbot remove <username> to leave a user out of the props. Requires write access.
• @propsbot refresh to refresh this list. Adding the props-bot label works too.

[huzaifaalmesbah]

Thanks @devmuhib009!

Properly unregisters custom post types foo, bar, and baz in tear_down() and cleans up the redundant mid-test unregistration calls in Tests_Post_GetPostsByAuthorSql. Verified random order execution. Looks good to me!

_{AI Review: Gemini 3.8 Flash}

[Copilot]

🟢 Approval recommended

No active review issues block the change centralizing custom post type cleanup in teardown.

No open issues 🎉

What changed in this PR

This PR improves test isolation in Tests_Post_GetPostsByAuthorSql by centralizing custom post type cleanup in teardown.

Changes:

• Adds tear_down() to unregister foo, bar, and baz using the public unregister_post_type() API before calling the parent teardown.
• Removes inline _unregister_post_type() calls so cleanup runs even when assertions fail.

File	Description
tests/​phpunit/​tests/​post/​getPostsByAuthorSql.php	Centralizes custom post type cleanup to prevent fixture leakage between tests.

_{Review effort: Balanced}