Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
🟡 Changes recommended
Reusing uploads by basename can attach incorrect fixture bytes and make separate attachments share a file, so deleting one can break the other.
1 open issue
What changed in this PR
This PR changes WordPress’s PHPUnit attachment factory to reuse existing uploads, aiming to avoid uploading the same test image repeatedly.
Changes:
- Checks for an existing file with the fixture’s basename in the current upload directory.
- Reuses its path and URL when present; otherwise uploads through
wp_upload_bits().
| File | Description |
|---|---|
| tests/phpunit/includes/factory/class-wp-unittest-factory-for-attachment.php | Adds an existing-file check and upload reuse to create_upload_object(). |
Review effort: Balanced
| $contents = file_get_contents( $file ); | ||
| $upload_dir = wp_upload_dir(); | ||
| $file_basename = wp_basename( $file ); | ||
| $file_path = $upload_dir['path'] . '/' . $file_basename; | ||
| if ( ! file_exists( $file_path ) ) { | ||
| $upload = wp_upload_bits( $file_basename, null, $contents ); | ||
| } else { | ||
| $upload = array( | ||
| 'file' => $file_path, | ||
| 'url' => $upload_dir['url'] . '/' . $file_basename, | ||
| ); | ||
| } |
|
Closing this file-reuse approach in favor of the isolated test-upload direction, tracked in #13065. Reusing files by basename can make distinct attachments share an owned file. The underlying collision issue remains open; #13065 has not landed. AI review · |
Testing instructions provided in OP
Trac ticket: https://core.trac.wordpress.org/ticket/63532
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.