fix(accounting): accept delivery contact addresses - #842
Open
miachillgood wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The live Accounting API can return
DELIVERYinContact.Addresses[].AddressType, while the reusableAddressschema only permitsPOBOXandSTREET. Generated SDKs with closed enums therefore fail to deserialize the entire contact.AddressForOrganisationalready includesDELIVERY; this aligns the contact address schema with the observed response and prevents the generated client failure reported in XeroAPI/Xero-NetStandard#666.Fixes XeroAPI/Xero-NetStandard#666.
Validation
xero_accounting.yamlsuccessfully with PyYAMLscripts/api-diff/api-diff.test.sh: 9/9 passedgit diff --checkThe change is an additive enum value; repository CI will run the official API-diff and code-generation validation.