Skip to content

fix(accounting): RECEIPT linked transactions and namespaced TaxNumberType - #846

Open
ryanduguid wants to merge 1 commit into
XeroAPI:masterfrom
ryanduguid:fix/accounting-enum-live-values
Open

fix(accounting): RECEIPT linked transactions and namespaced TaxNumberType#846
ryanduguid wants to merge 1 commit into
XeroAPI:masterfrom
ryanduguid:fix/accounting-enum-live-values

Conversation

@ryanduguid

Copy link
Copy Markdown

Summary

  • `LinkedTransaction.SourceTransactionTypeCode` is missing `RECEIPT`. The Accounting API returns it for receive-money bank transactions; xero-python then raises on deserialize (xero-python#206).
  • `Contact.TaxNumberType` GET payloads have been observed as `TAXNUMBERTYPE/SSN` (xero-python#203, #205). The enum members are unchanged; the description now records the namespaced form so the next SDK generate does not treat it as unknown.

Companion runtime workaround (does not wait on a regenerate): xero-python#243.

Test plan

  • Spec review that RECEIPT is a documented LinkedTransaction source type
  • Confirm TaxNumberType description is accurate for US contacts

GET Contact.TaxNumberType has been observed as TAXNUMBERTYPE/SSN.
LinkedTransaction.SourceTransactionTypeCode includes RECEIPT for
receive-money bank transactions, not only ACCPAY and SPEND.
@ryanduguid

Copy link
Copy Markdown
Author

The pull-request workflow runs are currently waiting for maintainer approval. Please approve them when convenient so CI can run against this revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants