Repository navigation
10.5.0 - #644
Merged
Merged
10.5.0#644
Conversation
The branch filter on pull_request kept stacked PRs, which target a feature branch, from running CI. Signing and publishing steps still run only on master and develop.
ComicDB is a value type with a ComicFile and a ComicInfo; ComicInfo::id is a ComicInfoId. The scanner uses DiskItem and the server folder content uses FolderContentItem instead of LibraryItem pointer lists. The reader stream keeps its layout. Fixes: the remote progress functions took the comic id inside ComicInfo::id; they now take a ComicId. The unused server v1 overload of updateFromRemoteClient is removed.
Changes: - the server lists send the real values of comic_info_id, path, file_type, parent_id, added, last_time_opened, cover_page and original_cover_size, and leave out NULL fields - the Reading and Recent reloads compare integer seconds, so rows are no longer removed and inserted again - reader updates, read state, type and rating change every row of the comic_info - the Continue Reading banner reads the rows instead of one query per comic; getAllComics and getComics use one query - folder, reading list and label loops read by column position - the remote progress readers no longer leak rows in takeUpdatedData
With the 7zip backend, the apps load the 7z library at runtime, and only the installers put it in place. Tests that read archives failed on every 7zip CI job. Executables now get the bundled library in utils/ after the build, and on Linux the library is also looked for there, after the installed paths.
Fixes: - removing a comic from a reading list with child lists removes it from the child list that holds it - appending to a reading list starts at the end of that list, not after the rows of all lists - the pre-9.5 cover step no longer commits the upgrade transaction - a failed reorder or removal reloads the list
Changes: - an unreadable replacement rolls back, so the comic keeps its row and its list entries and the next update tries again - a replacement with the same comic_info keeps coverPage - the old values are no longer copied over a known comic_info
This is critical because otherwise Android can crash.
Refine translations in yacreaderlibrary_zh_CN.ts
Dragging a file over/across the reader window, but not dropping it, would unlink the page progress from the library by setting isClient = false in dragEnterEvent before the file was actually dropped and the reader opened it. Reader skipped sendComic() on close, so the library silently lost the reading progress. isClient is set false when a file is actually opened with dropEvent already so the unlinking still works in that case.
Fixed dragging file across reader unlinking progress
When a comic opened from the file system could not be read, the reset that follows the error disabled the previous and next comic actions, so the shortcuts could not move on to the neighbouring files. The reset now updates those actions the same way the double manga page switch does.
The previous commit moved the body of doubleMangaPageSwitch into a new updatePrevNextActions() overload and left doubleMangaPageSwitch only forwarding to it. That overload shares its name with updatePrevNextActions(bool, bool) but works the state out instead of applying it. Since doubleMangaPageSwitch never did more than this, the two become one function, refreshPrevNextActions, in the place doubleMangaPageSwitch had, and every caller uses it.
…ssing Opening a recent file that no longer exists also resets the viewer, and the reset now sets the actions from the neighbours of the comic that was open before, while no comic is shown. Forgetting those neighbours first keeps the actions disabled there, as before, for comics not opened from the library. For comics opened from the library the reset works the actions out from the sibling list, so nothing changes there.
…le-comic Keep the previous and next comic actions after a file fails to open
…fault reader background
Update Simplified Chinese language pack
The v2 and v3 cover routes decoded each cover and encoded it again as JPEG for every request. The scaling that needed this was removed long ago, so the routes only spent CPU and lowered the quality. Every cover in a library is already a JPEG, so the routes now send the file. They also send an ETag and answer a matching If-None-Match with a 304. Custom covers replace the file under the same name, so browsers must revalidate and cannot cache them for a fixed time.
The reader saved the page only once, when leaving it, so a tab that the OS killed in the background could lose the progress. It now also saves when the tab is hidden, and it can save again if the reading continues after that. It does not send the same page twice.
The "Settings saved." message came back on every reload of the page.
Fix translations in yacreaderlibrary_zh_CN.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YACReader
YACReaderLibrary
Server
WebUI
All GUI apps