Skip to content

Include timeout because sometimes it takes too long - #6

Closed
shelbaz wants to merge 1 commit into
ZenRows:mainfrom
shelbaz:patch-1
Closed

Include timeout because sometimes it takes too long#6
shelbaz wants to merge 1 commit into
ZenRows:mainfrom
shelbaz:patch-1

Conversation

@shelbaz

@shelbaz shelbaz commented Jan 3, 2024

Copy link
Copy Markdown

No description provided.

@shelbaz shelbaz mentioned this pull request Jan 3, 2024
@AnderRV

AnderRV commented Aug 20, 2026

Copy link
Copy Markdown
Member

Thanks for this! Revisiting after a broader Fetch/Extract/Batch rework this session — a couple of things changed underneath this PR:

  • The premise ("timeout because sometimes it takes too long") is stale: client.py now forwards arbitrary **kwargs (including timeout=) straight to the underlying requests call, so a per-call timeout already works today without a code change.
  • What this PR actually adds beyond that — a constructor-level default timeout (so a call that doesn't pass one explicitly still doesn't hang forever) — is still a real, valid gap. It's just tangled up here with unrelated reformatting, and conflicts against current main.

Going to close this one rather than merge as-is, but the default-timeout idea is worth a fresh, small PR against the current client.py if you'd like to take another pass — happy to help scope it. Take into account that fetch requests can run up to 180 seconds. Adding a default timeout below that could cause issues for long lasting requests.

@AnderRV AnderRV closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants