fix: make member cache respect the fresh argument - #594
Open
Tomlacko wants to merge 1 commit into
Open
Conversation
This should fix a real issue I was encountering, when attempting to fetch a member that left, then later rejoined, which kept them in the unknownMembers cache, which was always hit despite fresh=true. As a result, it was impossible to mute this person via the bot.
|
Thank you for contributing to Zeppelin! We require contributors to sign our Contributor License Agreement (CLA). To let us review and merge your code, please visit https://github.com/ZeppelinBot/CLA to sign the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix a real issue I was encountering, when attempting to fetch a member that left, then later rejoined, which kept them in the unknownMembers cache, which was always hit despite fresh=true.
As a result, it was impossible to mute this person via the bot.