Repository navigation
fix(live): ending an HLS session leaves a reader others still use - #270
Merged
Merged
Conversation
The idle reaper ends a live session 90 s after its last HLS fetch, and stop_session stopped the monitor's stream-socket reader with it. A WebRTC, WHEP or RTSP viewer reads from that same reader and never touches the HLS session, so it lost its video a minute or two in. stop_session now waits for the session's task to finish and stops the reader only if nothing else subscribes to it. A reader it leaves running is remembered, and the idle watchdog stops it on a later pass once nothing reads it and no new session has taken it back. With nobody left at the time, the reader stops at once as before. Fixes #256 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KXE4e1KGijmQSLUde9ydBZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idle reaper ends a live session 90 s after its last HLS fetch, and
stop_session stopped the monitor's stream-socket reader with it. A
WebRTC, WHEP or RTSP viewer reads from that same reader and never
touches the HLS session, so it lost its video a minute or two in.
stop_session now waits for the session's task to finish and stops the
reader only if nothing else subscribes to it. A reader it leaves running
is remembered, and the idle watchdog stops it on a later pass once
nothing reads it and no new session has taken it back. With nobody left
at the time, the reader stops at once as before.
Fixes #256
🤖 Generated with Claude Code
https://claude.ai/code/session_01KXE4e1KGijmQSLUde9ydBZ