feat: Add providers to tanstack start - #761
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 694e7a2997
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| href: appCss, | ||
| }, | ||
| { charSet: 'utf-8' }, | ||
| { content: 'width=device-width, initial-scale=1', name: 'viewport' }, |
There was a problem hiding this comment.
The new application shell only declares the viewport dimensions and title, leaving out a page description, theme-color, and user-scalable configuration. Every route inherits this root head, so production pages will ship without the repository-required SEO and viewport metadata; add the missing fields here.
AGENTS.md reference: AGENTS.md:L46-L46
Useful? React with 👍 / 👎.
| * the no-flash script that paints the theme before React exists is rendered by | ||
| * the shell instead (see `components/theme-script.tsx`). | ||
| */ | ||
| export const VitNodeProviders = ({ |
There was a problem hiding this comment.
This introduces the public VitNodeProviders feature and changes framework ownership of Query, progress, and the no-flash theme script, but a repo-wide search of apps/docs/content and the other documentation sources finds no corresponding user documentation. Consumers therefore have no documented guidance on mounting this provider or pairing it with ThemeScript versus NextThemeScript; add a concise feature guide as required.
AGENTS.md reference: AGENTS.md:L59-L59
Useful? React with 👍 / 👎.
1 participant
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?