feat: Add layout in tanstack start - #767
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4147d2347
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| function MainLayout() { | ||
| return ( | ||
| <ThemeLayoutContent breadcrumb={<MainBreadcrumb />} header={<MainHeader />}> |
There was a problem hiding this comment.
The shell mounts MainBreadcrumb, but none of the routes under _main declares staticData.breadcrumb, so breadcrumbOf(useMatches()) always returns null. Consequently /discover and /search lose the explicit BreadcrumbMain navigation provided by their legacy counterparts; add breadcrumb declarations to the migrated route definitions, including explicit null where a child should clear an inherited crumb.
AGENTS.md reference: AGENTS.md:L26-L26
Useful? React with 👍 / 👎.
1 participant
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?