Skip to content

fix(ci): run cypress smoke without cypress-io/github-action - #3154

Merged
sammdec merged 2 commits into
mainfrom
fix/ci-cypress-wait-on-ipv4
Oct 27, 2026
Merged

sammdec merged 2 commits into
mainfrom
fix/ci-cypress-wait-on-ipv4

Conversation

@sammdec

@sammdec sammdec commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

All cypress smoke jobs have failed since 21 Oct with Socket closed before the connection was established. The failure happens about 20ms after pnpm serve:static starts, before any tests run.

Cause: GitHub runner 2.338.0 ships Node 24.21. Our pinned cypress-io/github-action@v3.0.3 pings wait-on with got@11. On Node >=24.20, that ping raises ERR_SOCKET_CLOSED_BEFORE_CONNECTION while the server is still booting, and got@11 doesn't retry it, so the job fails immediately. Upstream issue: cypress-io/github-action#1873.

Pinging 127.0.0.1 instead of localhost didn't help. Upgrading the action to v7 isn't an option either, because v7 dropped the command input that we use to run cypress-repeat.

Fix: drop the action and do what it did in plain steps:

  • start pnpm serve:static in the background
  • wait for it with curl --retry-connrefused (prints serve.log on timeout)
  • run TEST_COMMAND directly

Test plan

  • cypress_smoke_v3 jobs start the server, get past the wait and run tests on this PR

🤖 Generated with Claude Code

…ction

cypress-io/github-action v3 pings with got@11, which doesn't retry
ERR_SOCKET_CLOSED_BEFORE_CONNECTION raised by Node >=24.20 (runner 2.338.0)
when resolving localhost. Pinging the IPv4 address directly sidesteps it.
See cypress-io/github-action#1873.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
interface Ready Ready Preview Oct 27, 2026 11:04am UTC

Request Review

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.34 MB (🟡 +245 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Ten Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 93.7 KB (🟡 +199 B) 1.43 MB
/dashboard 82.21 KB (🟡 +40 B) 1.42 MB
/governance 43.24 KB (🟡 +59 B) 1.38 MB
/governance/ipfs-preview 97.64 KB (🟢 -87 B) 1.43 MB
/governance/v3/proposal 84.56 KB (🟡 +71 B) 1.42 MB
/markets 54.86 KB (🟡 +198 B) 1.39 MB
/reserve-overview 38.94 KB (-1 B) 1.38 MB
/safety-module 55.72 KB (🟡 +40 B) 1.39 MB
/sgho 92.82 KB (🟡 +40 B) 1.43 MB
/v3-migration 49.12 KB (🟡 +40 B) 1.39 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

The v3 action's wait-on ping errors immediately on Node >=24.20
(ERR_SOCKET_CLOSED_BEFORE_CONNECTION, cypress-io/github-action#1873),
and v7 no longer supports a custom command for cypress-repeat. Start
serve in the background, wait with curl retries, then run the tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sammdec sammdec changed the title fix(ci): wait on 127.0.0.1 in cypress action fix(ci): run cypress smoke without cypress-io/github-action Oct 27, 2026
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.34 MB (🟡 +251 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Ten Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 93.7 KB (🟡 +199 B) 1.43 MB
/dashboard 82.21 KB (🟡 +40 B) 1.42 MB
/governance 43.24 KB (🟡 +59 B) 1.38 MB
/governance/ipfs-preview 97.64 KB (🟢 -87 B) 1.43 MB
/governance/v3/proposal 84.56 KB (🟡 +71 B) 1.42 MB
/markets 54.86 KB (🟡 +198 B) 1.39 MB
/reserve-overview 38.94 KB (-1 B) 1.38 MB
/safety-module 55.72 KB (🟡 +40 B) 1.39 MB
/sgho 92.82 KB (🟡 +40 B) 1.43 MB
/v3-migration 49.12 KB (🟡 +40 B) 1.39 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@sammdec
sammdec merged commit 36acdef into main Oct 27, 2026
20 of 21 checks passed
@sammdec
sammdec deleted the fix/ci-cypress-wait-on-ipv4 branch October 27, 2026 11:16

This branch was successfully deployed

1 active deployment
Preview — ca87c5eb Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants