Skip to content

Avoid modulo in Polygon pixel test #11623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhalbert merged 1 commit into from
Oct 17, 2026
+5 −4
Merged

Avoid modulo in Polygon pixel test #11623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions shared-module/vectorio/Polygon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,12 @@ uint32_t common_hal_vectorio_polygon_get_pixel(void *obj, int16_t x, int16_t y)
int16_t winding_number = 0;
int16_t x1 = self->points_list[0];
int16_t y1 = self->points_list[1];
for (uint16_t i = 2; i <= self->len + 1; ++i) {
for (uint16_t i = 2; i <= self->len; i += 2) {
VECTORIO_POLYGON_DEBUG(" {(%3d, %3d),", x1, y1);
int16_t x2 = self->points_list[i % self->len];
++i;
int16_t y2 = self->points_list[i % self->len];
// The last edge closes the polygon back to the first point.
uint16_t next = i == self->len ? 0 : i;
int16_t x2 = self->points_list[next];
int16_t y2 = self->points_list[next + 1];
VECTORIO_POLYGON_DEBUG(" (%3d, %3d)}\n", x2, y2);
if (y1 <= y) {
if (y2 > y && line_side(x1, y1, x2, y2, x, y) < 0) {
Expand Down
Loading