Repository navigation
Use the 4.3 inch display on the ESP32-S31-Korvo-1 - #11630
Open
mikeysklar wants to merge 1 commit into
Open
mikeysklar wants to merge 1 commit into
mikeysklar wants to merge 1 commit into
Conversation
Sets up the 4.3 inch RGB panel that ships with the board as board.DISPLAY, using the timing from Espressif's esp32_s31_korvo_1 BSP, so boot messages and the REPL show on it. esp_lcd's RGB panel driver needs lcd_hal and the LCD signal tables, which live in esp_hal_lcd, so the ESP32-S31 build now links it. The other targets with an LCD peripheral already list it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Shows the REPL on a 4.3 inch display plugged into the ESP32-S31-Korvo-1.
Why
CircuitPython did not use the board's LCD connector.
CIRCUITPY_DOTCLOCKFRAMEBUFFER=1on S31soc_lcd_rgb_signalsandlcd_hal_*The ESP32, S2, S3 and P4 builds already list
esp_hal_lcd.bsp/esp32_s31_korvo_1/include/bsp/esp32_s31_korvo_1.h: 18 MHz, pclk on falling edge, h 40/40/48, v 23/32/13, about 35 HzEspressif's Korvo-1 user guide lists the 4.3 inch LCD subboard in its package contents.
AI assistance: written with Claude Code. I ran every test above on hardware.