Repository navigation
Fix the vsync idle setting for RGB displays on ESP32 - #11631
Merged
Merged
Conversation
The vsync idle level was taken from hsync_idle_low, so the vsync_idle_low argument was ignored. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mikeysklar
force-pushed
the
dotclock-vsync-idle
branch
from
October 19, 2026 03:04
02b97d0 to
ed0bdf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
vsync_idle_lownow sets the vsync idle level.Why
It was set from
hsync_idle_lowby mistake.The fix only matters when hsync and vsync idle values differ.
Not tested on hardware; no in-tree board changes behavior.
sunton_esp32_8048S050 builds.
AI assistance: written with Claude Code. I checked every caller above myself.