Repository navigation
test(release): accept next's storage version in the storage manifest check - #1675
Merged
Merged
Conversation
…check On next, adcp-reporting-storage releases its own 0.2.0-beta.N line from .release-please-manifest.next.json, but the storage version test only read main's manifest, so the 0.2.0-beta.0 release PR (#1674) failed every Test Python lane. Accept either manifest's storage entry, as the root version test already does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
![aao-secretariat[bot]](https://avatars.githubusercontent.com/u/221690821?s=60&v=4){kind=small}
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean single-file test fix.
Checked:
- Only
tests/test_release_configuration.pychanged (+9/-3). Accepts either main's or next's.release-please-manifest.next.jsonstorage entry, mirroring the root-version test's dual-manifest pattern, and guards the storage key's presence before indexing. - No wire-shape, public-surface, generated-code, or forward-compat impact; no credential/
ctx_metadataconcerns; CI gates remain armed (test is fixed, not disabled). - No reviewer findings.
Gate checks: no no-auto-approve team match, gated_paths false, high_risk false, no prior decision. Rows 1–8 do not fire → row 9 approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
adcp-reporting-storage0.2.0-beta.0 release PR (#1674) fails all four Test Python lanes on one test:On
next, storage releases its own0.2.0-beta.Nline from.release-please-manifest.next.json(#1663), but the test only readmain's manifest. This accepts either manifest's storage entry, the same waytest_worktree_version_matches_normalized_release_manifestalready does for the root package.Verified on
nextboth before the release (0.1.0b4) and with #1674's version state (0.2.0b0 / next manifest0.2.0-beta.0): 5 passed each time. It's atest:commit, so no release is triggered.🤖 Generated with Claude Code