Skip to content

feat(observability): observe HTTP response delivery - #13

Draft
afourniernv wants to merge 1 commit into
mainfrom
feat/5398-terminal-delivery/afourniernv
Draft

afourniernv wants to merge 1 commit into
mainfrom
feat/5398-terminal-delivery/afourniernv

Conversation

@afourniernv

@afourniernv afourniernv commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

Add passive delivery observations to the existing HTTP response span. This is independently based on main and #5214; it remains a separate, last-review item rather than depending on the other correlation follow-ups.

Related Issue

Closes NVIDIA#5398. Tracking: NVIDIA#5210.

Changes

  • Count accepted wire bytes, including headers/framing, and retain the first bounded downstream write, flush or shutdown failure.
  • Distinguish observed framing completion, EOF, incomplete responses, cancellation, upgrade and ambiguous successful return.
  • Report middleware replacement/stop paths conservatively as returned, not completed. Accepted writes do not prove peer receipt or application execution.
  • Preserve all I/O results, timeouts, parser behavior, middleware behavior and OCSF emission sites. Add no new buffers, tasks, public API or terminal audit summaries.

Integration note: this and credentials #10 add different stage fields in the same function. Preserve both field sets when combining them; neither depends on the other.

Release Notes

The response span distinguishes initial status from delivery observations. These fields supplement, rather than replace, the request's policy outcome.

Testing

  • Checks appropriate to the affected code and behavior pass

  • Unit tests added/updated (if applicable)

  • E2E tests added/updated (if applicable)

  • Independent network Nextest suite: 1,728 passed; seven skipped. All five focused delivery tests passed.

  • The new real whole-body middleware regression checks transformed response bytes and headers while requiring delivery_outcome=returned, not completed.

  • Existing delivery tests cover partial writes, framing, downstream failures, cancellation and close-delimited idle timeout versus EOF.

  • Full independent and combined pre-commit checks, including strict Clippy, passed. Combined Nextest: 1,892 passed; seven skipped. Network Cargo tests with telemetry disabled: 1,731 passed; two ignored.

  • Fresh Hermes/Relay execution verified premature framed-body EOF: client IncompleteRead, preserved HTTP 200 statuses, delivery_outcome=failed, positive accepted bytes and the response failure reason. Real response-middleware replacement remains returned, not completed. These live cases use the combined follow-up build; the independent suite above qualifies this branch alone.

  • The broad workspace task is not green: an unchanged packaging assertion reproduces on pinned main, and a separate VM image-preparation test failed once then passed in isolation. Those files are outside this change.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable): crate and published delivery guidance updated; subsystem boundaries unchanged.

@afourniernv
afourniernv force-pushed the feat/5398-terminal-delivery/afourniernv branch from 967d7d0 to ca088dc Compare November 17, 2026 17:27
@afourniernv
afourniernv force-pushed the feat/5397-mcp-correlation/afourniernv branch from d0f6e48 to 745d8e1 Compare November 17, 2026 17:27
@afourniernv afourniernv changed the title feat(observability): distinguish HTTP response selection from delivery failure feat(observability): observe terminal HTTP response delivery Nov 17, 2026
Signed-off-by: Alex Fournier <afournier@nvidia.com>
@afourniernv
afourniernv force-pushed the feat/5397-mcp-correlation/afourniernv branch from 745d8e1 to 185d4d6 Compare November 18, 2026 00:48
@afourniernv
afourniernv force-pushed the feat/5398-terminal-delivery/afourniernv branch from ca088dc to e888964 Compare November 18, 2026 00:48
@afourniernv afourniernv changed the title feat(observability): observe terminal HTTP response delivery feat(observability): observe HTTP response delivery Nov 18, 2026
@afourniernv
afourniernv changed the base branch from feat/5397-mcp-correlation/afourniernv to main November 18, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(observability): distinguish HTTP response selection from delivery failure

1 participant