Refonte page mode de passe oublié - #2367
Open
vgreb wants to merge 2 commits into
Open
Conversation
Mopolo
reviewed
Aug 26, 2026
Contributor
There was a problem hiding this comment.
Un test avec autant de mocks ne me parait pas une bonne idée.
Ce serait mieux, soit d'avoir un test behat, soit de s'en passer.
Là les seuls assertions sont sur des mocks donc on se retrouve juste avec une copie de code, peu d'intérêt et cela rend le test beaucoup trop lié à du code privé.
Collaborator
Author
There was a problem hiding this comment.
J'ai remplacé ce test par un scenario Behat
vgreb
force-pushed
the
front/forgot-password
branch
from
August 26, 2026 17:02
3852899 to
15b5a38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
J'ai aussi corrigé le comportement à la soumission du formulaire dans le cas d'un email inconnu, on affiche maintenant un message neutre pour éviter l'énumeration des comptes.