fix: time out stuck app-server RPCs and cancel before turn start - #434
Open
goodjin wants to merge 1 commit into
Open
fix: time out stuck app-server RPCs and cancel before turn start#434goodjin wants to merge 1 commit into
goodjin wants to merge 1 commit into
Conversation
Swallowing stdin write failures and waiting for turn/start made cancel deadlock when Codex stopped responding. Surface write/backpressure errors, bound JSON-RPC waits, and release pending turn starts on cancel. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
turn/interrupt, override withCODEX_RPC_TIMEOUT_MS).session/cancelno longer waits forturn/start. It aborts the open prompt immediately; a late-started turn is still interrupted.This showed up as a prompt that produced no
session/updatefor minutes, with cancel also hanging until the adapter process was killed. Close already released a pending turn start; cancel did not, so both sides waited on each other.Test plan
npm run typechecknpm test(461 passed, 28 skipped)turn/startis still outstandingturn/startstill getsturn/interruptMade with Cursor