fix: persist ACP model and reasoning effort across turns and resume - #457
Open
superbiche wants to merge 13 commits into
Open
fix: persist ACP model and reasoning effort across turns and resume#457superbiche wants to merge 13 commits into
superbiche wants to merge 13 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes #394 with the same narrowly scoped persistence fix rebased onto upstream
main/ v1.8.0. The earlier PR cannot be updated without rewriting its published branch history.What changes:
modelandreasoning_effortconfiguration updates are persisted withthread/settings/updateand acknowledged only after Codex accepts them. A setting therefore remains effective for subsequent turns and process reconnects until changed.modelProviderwhen no provider is configured, allowing the Codex thread to retain its stored model and reasoning effort.thread/settings/updateis in flight.Validation on the final candidate (
4014f8b):npm run typecheck: passnpm test: 495 passed, 26 skippednpm run build: pass (all release bundles)gpt-5.6-sol/highrequest receipts, thread settings, and exact rolloutturn_contextentriesKnown boundary: when an explicit model provider is configured, app-server resume/load/fork re-resolves model and effort from that provider. Stored settings are retained across those operations only when no provider override is supplied; within a live session, later turns retain settings normally.
Fixes #336.
Fixes #343.
@superbiche · user · drafted with Codex (GPT-5).