Repository navigation
chore: the console team owns the repository, infra owns CI - #140
Open
Gkrumbach07 wants to merge 2 commits into
Open
Gkrumbach07 wants to merge 2 commits into
Gkrumbach07 wants to merge 2 commits into
Conversation
The workflows, the release scripts and the upstream bump bot hold the tokens that publish packages and push branches. Simon asked for the organization's infra team to review changes to them; this makes @ai-openshell/infra the code owner of .github/, scripts/release/, scripts/retag-image.sh, scripts/branch-tip.sh and deploy/ci/upstream/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Gage Krumbach <gkrumbac@redhat.com>
CODEOWNERS named only Gkrumbach07, and main-integrity needs one code owner's approval, so no pull request of his could merge. The default owner is now the ai-openshell/console team (Gkrumbach07 and danreed-rh), as sdk-go uses ai-openshell/sdk, so each maintainer can approve the other's work. The ADR and auth rules named the same owner as the default and are dropped. The root CODEOWNERS goes: .github/CODEOWNERS takes precedence, so it was dead. scripts/quay-login.sh (ai-openshell#134) joins the files infra reviews. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Gage Krumbach <gkrumbac@redhat.com>
danreed-rh
approved these changes
Nov 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #135, rebased onto
mainand opened from my fork.Why
main-integrityneeds one code owner's approval to merge, and CODEOWNERS names only me, so none of my pull requests can merge (#134, #138 and #139 are all blocked). Separately, Simon asked that changes to CI get a security review from infra.What changes
The console team owns the repository by default.
* @ai-openshell/console, the org team of the console's maintainers (Gkrumbach07,danreed-rh). It has two members, so each can approve the other's PRs. Being a team means a maintainer joins or leaves in the org's team settings, not in this file. This is how sdk-go does it with@ai-openshell/sdk.Infra owns CI and release automation.
@ai-openshell/infraowns:.github/: the workflows and CODEOWNERS itselfscripts/release/,scripts/retag-image.sh,scripts/branch-tip.sh: whatpublish.ymlandpromote-latestrunscripts/quay-login.sh: the Quay sign-in from ci: publish to quay.io through the release environment with a GitHub OIDC robot, pin actions #134deploy/ci/upstream/: the bump bot, which runs with the bump-bot App's tokenThese lines come after the default, and the last matching rule wins, so for these paths a change needs an approval from someone in
infra.The root
CODEOWNERSis removed..github/CODEOWNERStakes precedence, so the root file was ignored. The separate ADR and auth rules named the same owner as the default, so they're gone too.Both teams have write on the repo (checked through the team API), so GitHub counts them as owners.
Merging this needs an admin
Under the current rules, the owner of
CODEOWNERSis only me, and I can't approve my own PR. An org admin has to approve or bypass once. After that, Dan and I can approve each other, and infra approves CI changes.🤖 Generated with Claude Code