Skip to content

chore: follow the Go SDK at ai-openshell/sdk-go - #141

Open
Gkrumbach07 wants to merge 1 commit into
ai-openshell:mainfrom
Gkrumbach07:sdk-go-module
Open

Gkrumbach07 wants to merge 1 commit into
ai-openshell:mainfrom
Gkrumbach07:sdk-go-module

Conversation

@Gkrumbach07

Copy link
Copy Markdown
Contributor

The Go SDK moved out of NVIDIA/OpenShell. It is now the module github.com/ai-openshell/sdk-go. Its tag vX.Y.Z is the SDK for core vX.Y.Z, and sdk-go cuts that tag after core releases. sdk/go/v0.1.8 is the last tag at the old path, so on the next core release Follow upstream would find no SDK.

Follow upstream

  • plan reads the target's SDK tag from sdk-go with git ls-remote. When sdk-go has not tagged the release yet:
    • the target's sdk is null and sdk_waiting_for says why;
    • the bump output is false, and publish.blocked refuses too;
    • the run summary says the bump waits;
    • check A, which needs no SDK, still runs;
    • no other SDK version or commit is pinned in its place.
  • The pin move runs go get github.com/ai-openshell/sdk-go@vX.Y.Z, then checks with go list -m -json that the tag is the commit plan read.
  • Off the old path: a go.mod still on github.com/NVIDIA/OpenShell/sdk/go is valid. The pin move that takes it to sdk-go rewrites backend/**/*.go to the new import path before go mod tidy. bump.py lets it commit exactly those files along with the pins. The rewrite therefore lands on the bump branch the workflow makes. The pins are never moved by hand (hard fact 17), and this PR does not move them: main stays on 0.1.6 and the old path.
  • The commit message and PR body of that bump say the SDK moved.

Pins check: follow.py validate-pins --go-mod and scripts/gateway-range.mjs --check read the SDK from either module path. The rule that sdk must equal go.mod holds before and after the move.

Docs: these now say where the SDK comes from and that the bump waits for its tag:

  • .claude/rules/openshell-api.md (hard facts 17 and 20) and .claude/rules/bff-go.md
  • the proto-sync skill
  • ADR 0003, and ADR 0005 (new amendment A7)
  • docs/architecture.md and deploy/ci/upstream/README.md

Tested

  • python3 -m unittest discover -s tests -t . in deploy/ci/upstream: 296 pass. New tests cover:
    • the SDK tag present, and the SDK tag missing (wait; an older tag is not taken instead);
    • an sdk-go outage;
    • a tag that moved between plan and bump;
    • the move off the old path, and committing the rewritten files;
    • both module paths in the pins check.
  • node --test "scripts/**/*.test.mjs": 89 pass.
  • On a scratch copy of this branch, the real pin move to 0.1.8 with the real go tools rewrote 74 Go files and left no old-path reference. go build ./..., go vet ./... and go test ./... pass on the result. Nothing from that run is committed.

The bump still can't open its PR until the bump-bot App secrets exist. That is separate org-admin work.

🤖 Generated with Claude Code

The Go SDK left NVIDIA/OpenShell: it is now the module
github.com/ai-openshell/sdk-go, whose tag vX.Y.Z is the SDK for core
vX.Y.Z, cut after core releases. sdk/go/v0.1.8 is the last tag at the
old path, so the next core release would have no SDK where Follow
upstream looks.

Follow upstream now reads the target's SDK tag from sdk-go. While sdk-go
has not tagged the release, the plan has no SDK, the bump output is
false and the run summary says the bump waits; check A still runs.
Nothing else is pinned in its place. The pin move runs `go get
github.com/ai-openshell/sdk-go@vX.Y.Z` and checks with `go list -m -json`
that the tag is the commit the plan read.

A tree still on github.com/NVIDIA/OpenShell/sdk/go stays valid (the pins
check in CI and gateway-range.mjs read either path), and the pin move
that takes it to sdk-go rewrites backend/**/*.go to the new import path
in the same commit; bump.py lets it commit exactly those files. So the
import rewrite lands on the bump branch, not by hand (hard fact 17).

Rules, ADR 0003, ADR 0005 (amendment A7), architecture.md and the
upstream README say where the SDK comes from now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Gage Krumbach <gkrumbac@redhat.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant