Skip to content

fix(vm): keep the compute driver socket under sun_path - #5050

Open
ericcurtin wants to merge 3 commits into
ai-openshell:mainfrom
ericcurtin:fix/5015-vm-driver-socket-path/ericcurtin
Open

ericcurtin wants to merge 3 commits into
ai-openshell:mainfrom
ericcurtin:fix/5015-vm-driver-socket-path/ericcurtin

Conversation

@ericcurtin

@ericcurtin ericcurtin commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Put the VM compute driver socket in a short private /tmp directory so it fits macOS sun_path.

Related Issue

Closes #5015

Changes

  • Move the private socket root allocator from the VM driver to openshell-core and share it.
  • The gateway puts compute-driver.sock in a new /tmp/os-<uid>-<random>/ and removes it on shutdown or failed launch.
  • Over-long socket paths name the path, length, and limit.

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

cargo fmt, cargo clippy -D warnings, and lib tests for core, gateway, VM driver, and server pass. Not run on macOS.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@krishicks @mrunalp PTAL, and /ok to test dad581be9bd66e0599d4909c80a669e811857bcd if it looks good. #5015 needs state:accepted for the acceptance check. Thank you!

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@drew @pimlock PTAL when you get a chance, and /ok to test dad581be9bd66e0599d4909c80a669e811857bcd if it looks good. Thank you!

@shiju-nv

shiju-nv commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Related: #4184 also covers other configured socket paths and long sandbox IDs.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

Thanks @shiju-nv. This one is the minimal fix for #5015. Happy to close it if #4184 lands first.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@krishicks @shiju-nv PTAL when you get a chance, and /ok to test dad581be9bd66e0599d4909c80a669e811857bcd if it looks good. Thank you!

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@TaylorMutch @drew PTAL when you get a chance, and /ok to test dad581be9bd66e0599d4909c80a669e811857bcd if it looks good. Thank you!

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@elezar @SDAChess PTAL when you get a chance, and /ok to test dad581be9bd66e0599d4909c80a669e811857bcd if it looks good. #5015 also needs state:accepted for the acceptance check. Thank you!

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@johntmyers @matthewgrossman PTAL when you get a chance, and /ok to test dad581be9bd66e0599d4909c80a669e811857bcd if it looks good. Thank you!

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@ericcurtin

Copy link
Copy Markdown
Contributor Author

Merged main, conflict in lib.rs resolved. The failing check is the issue acceptance gate: #5015 needs state:accepted from a maintainer. Still happy to drop this if #4184 lands first.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

Merged main (a04df39). @shiju-nv @drew PTAL, and could you please approve the pending workflow runs? Thank you!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(vm): gateway compute-driver.sock path can exceed macOS sun_path limit

2 participants