Repository navigation
ci: exercise branch checks on gke runners - #5867
Draft
TaylorMutch wants to merge 6 commits into
Draft
TaylorMutch wants to merge 6 commits into
TaylorMutch wants to merge 6 commits into
Conversation
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Comment on lines
+53
to
+70
| run: | | ||
| set -euo pipefail | ||
| # Pod environment is visible to the shell, not the workflow env context. | ||
| if [[ -z "${OPENSHELL_PERSISTENT_CACHE:-}" ]]; then | ||
| exit 0 | ||
| fi | ||
| echo "enabled=true" >> "$GITHUB_OUTPUT" | ||
| test "$GITHUB_REPOSITORY" = ai-openshell/openshell | ||
| test "$OPENSHELL_PERSISTENT_CACHE" = /mnt/ci-cache | ||
| mountpoint -q "$OPENSHELL_PERSISTENT_CACHE" | ||
| cache_root="$OPENSHELL_PERSISTENT_CACHE/ai-openshell-openshell/$NIX_SHELL_HASH" | ||
| mkdir -p "$cache_root/target" | ||
| echo "CARGO_TARGET_DIR=$cache_root/target" >> "$GITHUB_ENV" | ||
| echo "Persistent cache lane: $OPENSHELL_CACHE_LANE" | ||
| echo "Runner pod: $RUNNER_NAME" | ||
| echo "Target directory: $cache_root/target" | ||
| du -sh "$cache_root/target" | ||
| df -h "$cache_root/target" |
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. rust-sdk — No explicit risk acceptance foundThe exhaustive
Review details
Advisory review; publication gates are unchanged. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exercise Linux amd64 Branch Checks on GKE ARC runners. Trusted same-repository jobs use ARC; fork PRs, ARM jobs, and macOS jobs retain hosted runners. Trial isolated persistent Cargo caches for x86 lint and tests.
Related Issue
Closes #5866
Changes
openshell-ci-amd64-pd-lintandopenshell-ci-amd64-pd-test, each with one worker and a dedicated exclusive 200 GiB SSD disk.Release Notes
Testing
ReadWriteOncePod; temporary probe removed.Times include setup and cleanup but exclude queue time. Lint compile/check log counts fall from 475/1160 to 12/102. Test compile/check counts fall from 1525/206 to 974/112. The replacement pods start with 4 GiB and 31 GiB target directories respectively, and neither restores nor saves a GitHub Cargo archive. Test cache reuse succeeds after reattachment on a different node. Warm test queue time is 4m05s due to build-pool scale-up/image startup, versus 2m45s on the empty pass; including queue time, test duration improves from 20m15s to 14m45s. One pair of runs is observational and does not isolate CPU contention or sccache warming. An earlier run was canceled to correct pod-environment detection and is excluded from measurements.
The persistent disk trial also consolidates each job's target directories, so comparison with the older archive experiment does not isolate storage alone. Empty/warm runs on the same commit measure reuse across runner replacement. Fresh checkout timestamps and different build configurations can still cause recompilation. Trial lane concurrency is one job per lane; the ordinary ARC pool remains 5–20. Nix sandbox and trust settings are unchanged.
Checklist