Repository navigation
chore(renovate): remove the security-tool exemption and vulnerability-fix automerge - #134
Open
aig-hannes wants to merge 2 commits into
Open
aig-hannes wants to merge 2 commits into
aig-hannes wants to merge 2 commits into
Conversation
Part of OP-3647.
|
OX Security reviewed this pull request — nothing to fix.
Branch |
Codecov Report✅ All modified and coverable lines are covered by tests. |
The org config keeps automerge off for vulnerability fixes, which skip the 14-day release-age wait. This repo turned it back on. Part of OP-3649. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aig-hannes
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This repo's Renovate config skips the 14-day release-age wait for Trivy and pip-audit. A repo config overrides the org config, so these tools get updates on release day. A bad or compromised release would reach this repo before anyone upstream finds the problem.
The org config in aignostics/renovate-config sets the 14-day wait for every repo. Security fixes still skip the wait through
vulnerabilityAlerts.How
Removed the
packageRulesentry that setsminimumReleaseAge: nullfor the security tools. No other change.Verified
renovate-config-validatorpasses on the changed file.Also: vulnerability fixes no longer merge automatically
This PR also removes
"automerge": truefromvulnerabilityAlerts. A vulnerability fix skips the 14-day wait, so the fixed version can be hours old. The org config setsautomerge: falsefor these PRs so that a person checks the fix before the merge, but this repo's setting turned automerge back on. Part of OP-3649.renovate-config-validatorpasses on the changed file.Part of OP-3647. Please review and merge.
🤖 Generated with Claude Code
https://claude.ai/code/session_014JLwMr7Civ6B8Lk8B7b79U