Repository navigation
Fix product-card link styles and define compare-and-swap - #49
Merged
Merged
Conversation
Bare <a class="ax-card"> inherited the browser's visited colour and underline, so every line on /products/ looked like a link. Treat card-as-link as a flex card with body colour and the status pinned to the bottom. Spell out CAS on /sync/.
Deploying aixgo with
|
| Latest commit: |
16c55bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c6aba04a.aixgo.pages.dev |
| Branch Preview URL: | https://fix-product-cards-and-cas.aixgo.pages.dev |
The earlier pass added flex, min-height, and a focus ring. Those were new design. Guides already use ax-listcard for text-decoration: none; the product and homepage sibling cards now do the same.
The previous Pages check failed instantly after a follow-up push. Lint was green. Empty commit to get a new preview build.
text-wrap: balance plus overflow:hidden on the hero can clip a short title on a narrow viewport. List cards inherit colour so a visited link cannot leak through an unstyled child.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
/products/and the homepage "Also from us" band wrapped each product in<a class="ax-card">. Guides already use.ax-listcard(display: block; text-decoration: none) for the same card-as-link pattern. Without that class, headings, body copy and status lines inherited the browser's visited colour and underline.CAS was shown as a stat with no definition.
What
ax-card ax-listcard, the same class as guides and blog. No new card identity..ax-listcardalso inherits colour so a visited link cannot leak through an unstyled child.text-wrap: balancewould keep a short title on one overflowing line (the hero usesoverflow: hidden)./sync/has a Compare-and-swap section. The hero stat spells the acronym out.Check
make build && make lint.