Repository navigation
test(orchestrator): record what the SIGKILL resume test observes - #5
Merged
Merged
Conversation
TestSIGKILLResume now writes down each step it checks (the dead runner's state, the refused second runner, the stale-lease takeover, the reconciled attempt, the task's event log and the final state) and compares the sequence with testdata/crash-replay.json. Any difference fails the test, so a passing CI run proves the file is what a real kill and resume produced; -update-replay rewrites it when behaviour changes on purpose. Task ids and wall-clock times are normalised so the file is identical on every run. This gives readers (and the portfolio's replay of the test) a transcript that cannot drift from the code. Signed-off-by: akynte <104795207+akynte@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestSIGKILLResumenow writes down each step it checks and compares the sequence withinternal/orchestrator/testdata/crash-replay.json. Any difference fails the test, so a passing CI run proves the file is what a real kill and resume produced.Steps recorded (each is a value the test reads, not a description):
Waitreturns;Task ids and wall-clock times are normalised, so the file is identical on every run (checked 10 times locally, and under
-race).-update-replayrewrites it when behaviour changes on purpose.Test-only change: no production code is touched.
go vet ./...andgo test -race ./...pass.