[kai-nguyen-aligent]

Description of the proposed changes

• Add a settle-wait step and retry-on-push loop (matching the pattern already used in the PR-preview workflow) to gadget-deploy.yml's deploy job, so pushing to the freshly-created temp environment doesn't race Gadget's background file copy
• Remove the test job, the test input, and the gadget-test-api-key secret from gadget-deploy.yml, since the job did nothing beyond invoking yarn test which is redundant.
• Rename gadget-api-token to ggt-cli-token because they are different thing in Gadget.
• Update docs/gadget-deploy.md and README.md to match

Notes to reviewers

• Toggl Code: PJH-146: Code Review
• We only have couple of projects that use Gadget and only 2 of them are using this reusable workflow so updating is easy.
• When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

[kai-nguyen-aligent]

@Zigr1 @aligent-phil It would be good if you can setup your workflows to use this so we no longer need to do things in Gadget console.
@jackmacaa @michael-west-aligent tag you 2 for updating yours.

[AdamJHall]

@kai-nguyen-aligent,

Approved, just wondering though do we have a contact at Gadget we can ask about adding a --wait flag so we don't need the sleep?

[jackmacaa]

@kai-nguyen-aligent,

Approved, just wondering though do we have a contact at Gadget we can ask about adding a --wait flag so we don't need the sleep?

There is a Discord channel we can contact them on, also Jarrod would have one of their email addresses.