Skip to content

Experimental tools checked on SolidWorks and promoted to stable (2.0.0) - #220

Merged
andrewbartels1 merged 16 commits into
mainfrom
feat/experimental-tools
Nov 13, 2026
Merged

andrewbartels1 merged 16 commits into
mainfrom
feat/experimental-tools

Conversation

@andrewbartels1

Copy link
Copy Markdown
Owner

Item 8 in the work queue: each of the ten experimental tools gets a live test on SolidWorks 2026, its faults are fixed, and all ten move to stable. No tool is experimental now. This is part of 2.0.0, and v2.0.0 is tagged on this branch's last commit.

Breaking changes

  • More inputs that did nothing are refused, as in item 7:
    • compare_templates' six comparison switches;
    • generate_vba_code's parameters and code_style.
  • pack_and_go_assembly's inputs and reply change.
    • source_path and target_dir are required, and export_preview is off by default.
    • Its reply drops save_statuses and all_files_saved; unsaved_changes replaces them.
  • get_dimension returns its unit: mm for a length, deg for an angle, and null for a count.

Found by the live runs

  • Pack and Go copied only the assembly. On SolidWorks 2026, IPackAndGo.GetDocumentNames lists the assembly alone, so the copy had no parts, yet the tool reported success. It now copies each file GetDependencies2 lists into the target folder. The copy opens with its own parts, because SolidWorks looks in the assembly's folder before the stored path.
    • The tool closes nothing and keeps any other files in the folder.
    • Its warning names open parts whose unsaved changes aren't in the copy.
    • It fails without copying anything when a file is missing, when two files share a name, or when the target folder holds the originals.
    • comtypes, used only by the old path, is no longer a dependency.
  • classify_feature_tree misnamed real parts. It called a plain extruded part an assembly, because "Material " contains "mate". After that fix it called the part sheet metal, because "fold" is inside "folder". Now the document type decides, and folder rows are skipped.
  • close_model failed on a second close in a row. SolidWorks activates another document after a close, so the tool now reads ActiveDoc first.
  • list_configurations, load_part and load_assembly always said "Default". They called IConfiguration.GetName(), which doesn't exist; they now read Name. open_model had the same fault and is fixed too.
  • The generated macro wouldn't run. SolidWorks runs a .swb macro only through a Sub named main. A diagnostic test ran each construct of the macro separately to find this. The macro now opens with Sub main(), which calls the named Sub.
  • Re-saved drawings differ. A drawing saved again with no change is not byte-identical, and compare_drawing_versions' description now says so.

Checks

  • Live: the tests in tests/live/test_live_sw_experimental_tools.py pass on SolidWorks 2026, in three batches run with the maintainer watching.
  • Mock suite: 3,833 passed at 100% coverage. Ruff is clean, mkdocs build --strict passes, and all 46 OpenSpec specs validate.
  • Skill: the limits page gains rows for Pack and Go copying files as saved, and for drawing re-saves.

OpenSpec change: archived in this PR as openspec/changes/archive/2026-11-12-experimental-tools-to-stable, with the queue updated.

…s or empties its folder, dimensions in their own units, the real configuration, a VBA skeleton that runs; unused inputs refused

Item 8 in the work queue (openspec change experimental-tools-to-stable).
Live tests written in tests/live/test_live_sw_experimental_tools.py; not run
yet. open_model and list_configurations called IConfiguration.GetName, which
doesn't exist, so they always reported an assumed Default; they read Name.
…rial'; a known document type decides (live batch 1)
… reported success with only the assembly copied (live batch 2)
…orks 2026's Pack and Go copied only the assembly (live batch 2)
…table; a diagnostic for the generated macro's .swb run

generate_vba_code stays experimental: RunMacro2 rejected its macro with no
reason. The skill's limits page gains rows for Pack and Go copying saved
files and for drawing re-saves never being byte-identical.
… named Sub

SolidWorks runs a .swb macro only through main: the live diagnostic ran every
construct of the generated macro, but a Sub with any other name failed with
no reason. execute_macro now runs the macro with its default procedure.
Its macro ran on a part, and on a drawing it stopped at the type check
without changing it. No tool is experimental now, so the unused
experimental-support constant goes.
uv.lock is refreshed: it still listed the project as 1.4.0 and missed
dependencies pyproject.toml already declared. The 2.0.0 CHANGELOG gains the
macro's Sub main, the dependency and the end of the experimental level, and
takes today's release date.
… the queue

Its delta specs join the main specs (pack-and-go, vba-skeleton,
dimension-reading, document-inspection, file-comparison), each with a
written Purpose.
@andrewbartels1
andrewbartels1 merged commit 2350929 into main Nov 13, 2026
19 checks passed

This branch was successfully deployed

1 active deployment
pypi — fce406e5 Deployed Nov 13, 2026 by andrewbartels1 via publish-pypi #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant