Skip to content

Monitor stand follow-ups: feature order, dimension listing, STL options, sketch on a face - #228

Merged
andrewbartels1 merged 7 commits into
mainfrom
fix/monitor-stand-follow-ups
Nov 15, 2026
Merged

andrewbartels1 merged 7 commits into
mainfrom
fix/monitor-stand-follow-ups

Conversation

@andrewbartels1

Copy link
Copy Markdown
Owner

Fixes the six faults found while building the monitor stand demo (#206).

What changed

  • list_features returns rows in tree order. The walk is shared (feature_walk.walk_feature_tree) and sorted by position, so verify_model now counts an agent's Plane1 and skips Front Plane.
  • list_model_dimensions with no feature finds every dimension. The old forward-only walk reached 0 features on the monitor stand; the shared walk reaches all of them. Each dimension is listed once, under the feature its @ suffix names.
  • export_stl keeps its STL options. IModelDocExtension.SaveAs2 takes eight arguments (by-reference Errors and Warnings); it was called with six of the wrong types and always fell back to SaveAs3. If the fallback is ever used, the reply's warning says so.
  • create_sketch takes face_point ([x, y, z] mm) to sketch on a flat face of the body. A point off the body, or on a curved face, fails with invalid_input.
  • The monitor stand demo sketches its pocket on the top face (so it follows a changed height), turns to isometric after each feature, and has a re-recorded GIF.

Checks

  • Mock suite: 3,869 passed, 100% coverage; ruff clean; mkdocs build --strict; openspec validate --all.
  • Live on SolidWorks 2026, all pass: feature order and verify_model with a plane; the dimension listing on the stand; STL export through SaveAs2 with no warning; sketch on a face (cut of 300 mm³; the air and a fillet refused); the pocket follows the stand raised from 66 to 70 mm.

OpenSpec change archived as 2026-11-14-monitor-stand-follow-ups.

Item 10 honest-tool-list (#174), 11 part-feature-depth (#105),
12 drawing-pack (#102), 13 configuration-tools, 14 tool-discovery-mode
(#176); sheet metal (#57) queued as item 15.
list_features in tree order; verify_model counts the agent's planes;
list_model_dimensions lists each dimension once under its owner, through
the walk list_features uses; export_stl calls SaveAs2 with its seven
arguments and warns when the SaveAs3 fallback writes the file;
create_sketch takes face_point; the monitor stand demo sketches its pocket
on the top face and turns the camera after each feature.
@andrewbartels1
andrewbartels1 merged commit b6e9d76 into main Nov 15, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant