Repository navigation
Monitor stand follow-ups: feature order, dimension listing, STL options, sketch on a face - #228
Merged
Merged
Conversation
…_design_table before removing it
list_features in tree order; verify_model counts the agent's planes; list_model_dimensions lists each dimension once under its owner, through the walk list_features uses; export_stl calls SaveAs2 with its seven arguments and warns when the SaveAs3 fallback writes the file; create_sketch takes face_point; the monitor stand demo sketches its pocket on the top face and turns the camera after each feature.
…est reads the name from create_sketch
…args are plain 0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the six faults found while building the monitor stand demo (#206).
What changed
list_featuresreturns rows in tree order. The walk is shared (feature_walk.walk_feature_tree) and sorted by position, soverify_modelnow counts an agent'sPlane1and skipsFront Plane.list_model_dimensionswith no feature finds every dimension. The old forward-only walk reached 0 features on the monitor stand; the shared walk reaches all of them. Each dimension is listed once, under the feature its@suffix names.export_stlkeeps its STL options.IModelDocExtension.SaveAs2takes eight arguments (by-referenceErrorsandWarnings); it was called with six of the wrong types and always fell back toSaveAs3. If the fallback is ever used, the reply'swarningsays so.create_sketchtakesface_point([x, y, z] mm) to sketch on a flat face of the body. A point off the body, or on a curved face, fails withinvalid_input.Checks
mkdocs build --strict;openspec validate --all.verify_modelwith a plane; the dimension listing on the stand; STL export throughSaveAs2with no warning; sketch on a face (cut of 300 mm³; the air and a fillet refused); the pocket follows the stand raised from 66 to 70 mm.OpenSpec change archived as
2026-11-14-monitor-stand-follow-ups.