Repository navigation
Part of #156: docs: tool catalog pages drift from the generator, with no check; null sample payloads - #230
Closed
Vedant-200 wants to merge 2 commits into
Closed
Part of #156: docs: tool catalog pages drift from the generator, with no check; null sample payloads#230Vedant-200 wants to merge 2 commits into
Vedant-200 wants to merge 2 commits into
Conversation
Owner
|
While I appreciate the thought, these seem like trivial changes, best practice is to use mocked fixtures in something like the conftest.py file for pytest variables. Also, it's worth mentioning I did some digging and noticed you've submitted 165 other PRs in over 100 Repos, while I don't know what your intent is, this does not make it seem like it's being done or had any oversight by a human. While I certainly don't have any qualms about use of AI, merging trivial changes by a bot is something I'm not looking to do. Thank you for your kind gesture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Adds a SAMPLE_MODEL_PATH constant to the catalog generator so path-like sample fields no longer render as null, and adds an integration test that regenerates the catalog into a temp folder and fails when any committed page differs.
How it was tested
Verified that the patch applies cleanly to
mainas it stands and that every patched file still parses.Checklist
pytest tests -m "not solidworks_only"passesmkdocs build --strictpasses, if docs changedtests/solidworks_mcp/<path>/test_<module>.py)require_success,ToolOperationError, ...) rather thantry/exceptPart of #156
Root cause
generate_tool_catalog.py emits null for path-like sample fields (e.g. model_path in generate_drawing_package/create_technical_drawing) because it has no realistic default path, and no check compares committed catalog pages against the generator's output.