Skip to content

Part of #156: docs: tool catalog pages drift from the generator, with no check; null sample payloads - #230

Closed
Vedant-200 wants to merge 2 commits into
andrewbartels1:mainfrom
devpilot-bot:fix/issue-156-mwhbnvbq
Closed

Vedant-200 wants to merge 2 commits into
andrewbartels1:mainfrom
devpilot-bot:fix/issue-156-mwhbnvbq

Conversation

@Vedant-200

Copy link
Copy Markdown

What and why

Adds a SAMPLE_MODEL_PATH constant to the catalog generator so path-like sample fields no longer render as null, and adds an integration test that regenerates the catalog into a temp folder and fails when any committed page differs.

How it was tested

Verified that the patch applies cleanly to main as it stands and that every patched file still parses.

Checklist

  • pytest tests -m "not solidworks_only" passes
  • Live SolidWorks run, if this touches COM behaviour (say which SolidWorks version)
  • mkdocs build --strict passes, if docs changed
  • Tests sit beside the module they exercise (tests/solidworks_mcp/<path>/test_<module>.py)
  • Tools use the error boundary helpers (require_success, ToolOperationError, ...) rather than try/except
  • No new claims in README or docs that a test or live run doesn't back up

Part of #156

Root cause

generate_tool_catalog.py emits null for path-like sample fields (e.g. model_path in generate_drawing_package/create_technical_drawing) because it has no realistic default path, and no check compares committed catalog pages against the generator's output.

@andrewbartels1

andrewbartels1 commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

While I appreciate the thought, these seem like trivial changes, best practice is to use mocked fixtures in something like the conftest.py file for pytest variables.

Also, it's worth mentioning I did some digging and noticed you've submitted 165 other PRs in over 100 Repos, while I don't know what your intent is, this does not make it seem like it's being done or had any oversight by a human. While I certainly don't have any qualms about use of AI, merging trivial changes by a bot is something I'm not looking to do. Thank you for your kind gesture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants