Repository navigation
Part of #157: chore: remove stale validate_coverage.py; decide whether mypy gates CI - #231
Closed
Vedant-200 wants to merge 1 commit into
Closed
Vedant-200 wants to merge 1 commit into
Vedant-200 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Removed the [tool.mypy] configuration and its two [[tool.mypy.overrides]] blocks from pyproject.toml, so mypy is no longer configured and editors stop flagging errors CI never enforced.
How it was tested
Verified that the patch applies cleanly to
mainas it stands and that every patched file still parses.Checklist
pytest tests -m "not solidworks_only"passesmkdocs build --strictpasses, if docs changedtests/solidworks_mcp/<path>/test_<module>.py)require_success,ToolOperationError, ...) rather thantry/exceptPart of #157
Root cause
pyproject.toml enables mypy with strict settings but CI never runs it, so the 40+ errors on main go unnoticed; the config is removed so editors stop flagging errors nobody will fix.