Skip to content

Part of #157: chore: remove stale validate_coverage.py; decide whether mypy gates CI - #231

Closed
Vedant-200 wants to merge 1 commit into
andrewbartels1:mainfrom
devpilot-bot:fix/issue-157-mwhbsigw
Closed

Vedant-200 wants to merge 1 commit into
andrewbartels1:mainfrom
devpilot-bot:fix/issue-157-mwhbsigw

Conversation

@Vedant-200

Copy link
Copy Markdown

What and why

Removed the [tool.mypy] configuration and its two [[tool.mypy.overrides]] blocks from pyproject.toml, so mypy is no longer configured and editors stop flagging errors CI never enforced.

How it was tested

Verified that the patch applies cleanly to main as it stands and that every patched file still parses.

Checklist

  • pytest tests -m "not solidworks_only" passes
  • Live SolidWorks run, if this touches COM behaviour (say which SolidWorks version)
  • mkdocs build --strict passes, if docs changed
  • Tests sit beside the module they exercise (tests/solidworks_mcp/<path>/test_<module>.py)
  • Tools use the error boundary helpers (require_success, ToolOperationError, ...) rather than try/except
  • No new claims in README or docs that a test or live run doesn't back up

Part of #157

Root cause

pyproject.toml enables mypy with strict settings but CI never runs it, so the 40+ errors on main go unnoticed; the config is removed so editors stop flagging errors nobody will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants