fix(@angular/ssr): abort web request signal when node request is aborted - #33879
Open
alan-agius4 wants to merge 1 commit into
Open
fix(@angular/ssr): abort web request signal when node request is aborted#33879alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces abort handling for incoming Node.js requests by mapping the 'aborted' event to an AbortController signal on the created Web Request, with corresponding tests added for HTTP/1.1 and HTTP/2. Feedback suggests handling cases where the request is already aborted before the handler is registered, and cleaning up the event listener on 'close' to prevent potential memory leaks.
alan-agius4
force-pushed
the
fix-ssr-abort-signal
branch
from
August 19, 2026 09:26
f74bc4e to
5053c9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When converting a Node.js
IncomingMessageorHttp2ServerRequestinto a WebRequestobject in@angular/ssr, if the underlying Node request is aborted/closed prematurely, the WebRequestobject'ssignaldoes not abort.What is the new behavior?
Connects an
AbortControllerto theabortedevent on the Node.js request so that the WebRequest'ssignalis aborted whenever the incoming Node request is aborted.Does this PR introduce a breaking change?