feat(material/menu): add disabledInteractive input to MatMenuItem - #33693
feat(material/menu): add disabledInteractive input to MatMenuItem#33693jermowery wants to merge 1 commit into
Conversation
angular-robot
Bot
added
detected: feature
|
This was made with Jetski, internally at Google. I reviewed the code and it looks pretty similar to what I would have implemented myself |
|
Also worth noting that it seems like the menu keyboard navigation skips over disabled items right now. |
I wonder if the menu needs a bigger overhaul for a11y... |
4ef5c22 to
de6578a
Compare
This adds the `disabledInteractive` input to `MatMenuItem`, bringing its behavior in line with `MatButton`. When `disabledInteractive` is true, the menu item takes on the visual styling of a disabled item and prevents default action on click, but allows for focus, hover states, and pointer events. This is useful for conveying why an item is disabled via a tooltip. Fixes angular#33692
de6578a to
38d8ca5
Compare
|
cr/966590721 is the internal test of this, the TAP Train process is in progress |
|
TGP results are very positive Only two failing targets Both targets appear to be cases where aria-disabled is being set on the mat-menu-item but the menu item is being kept interactive, which I think could be solved by just using the very feature I am adding in this PR |
|
Fixed all of the tests, running TGP again |
|
Spoke a little too soon, now it passes http://test/OCL:966590721:BASE:967377509:1787171260610:8b1de062 |
2 participants
This adds the
disabledInteractiveinput toMatMenuItem, bringing its behavior in line withMatButton. WhendisabledInteractiveis true, the menu item takes on the visual styling of a disabled item and prevents default action on click, but allows for focus, hover states, and pointer events. This is useful for conveying why an item is disabled via a tooltip.Fixes #33692