Skip to content

feat(material/progress-bar): add a styling token for active indicator… #34029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdedieu wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

feat(material/progress-bar): add a styling token for active indicator… #34029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/material/progress-bar/_m2-progress-bar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

@return (
base: (
progress-bar-active-indicator-shape: 0,
progress-bar-active-indicator-height: 4px,
progress-bar-track-height: 4px,
progress-bar-track-shape: 0,
Expand Down
1 change: 1 addition & 0 deletions src/material/progress-bar/_m3-progress-bar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ $prefix: (mat, progress-bar);

@return (
base: (
progress-bar-active-indicator-shape: map.get($system, corner-none),
progress-bar-active-indicator-height: 4px,
progress-bar-track-height: 4px,
progress-bar-track-shape: map.get($system, corner-none)
Expand Down
1 change: 1 addition & 0 deletions src/material/progress-bar/progress-bar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ $fallbacks: m3-progress-bar.get-tokens();
overflow-x: hidden;
transition: opacity 250ms 0ms cubic-bezier(0.4, 0, 0.6, 1);

border-radius: token-utils.slot(progress-bar-active-indicator-shape, $fallbacks);

@crisbeto crisbeto Nov 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't doing much, because it only applies to the outer container, not the inner elements. Users can already do it by just targeting the host element.

@sdedieu sdedieu Nov 2, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One alternative could be to have the progress-bar-track-shape also affecting the active-indicator shape (.mdc-linear-progress border-radius). Would it makes more sense ?

$track-variable: token-utils.slot(progress-bar-track-height, $fallbacks);
$indicator-height-variable: token-utils.slot(progress-bar-active-indicator-height, $fallbacks);
height: max(#{$track-variable}, #{$indicator-height-variable});
Expand Down
Loading