Repository navigation
fix(cdk/dialog): aria-hidden not restored when dialogs from parent and child are closed - #34043
Open
ewerton336 wants to merge 1 commit into
Open
ewerton336 wants to merge 1 commit into
ewerton336 wants to merge 1 commit into
Conversation
…d child are closed The list of open dialogs is shared between a `Dialog` and its parent, but each instance was keeping track of the elements it hid from assistive technology separately. If a dialog opened by a child `Dialog` was closed while one opened by the parent was still open (or the other way around), the instance that closed the last dialog didn't know about the hidden elements and the `aria-hidden` attribute was never removed. These changes share the map of hidden elements with the parent, the same way as the list of open dialogs. Fixes angular#30028
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
Dialogis provided at the component level, it shares its list of open dialogs with theparent
Dialog, but each instance tracked the elements it hid witharia-hiddenseparately.Opening a dialog from a child
Dialogand then one from the parent (or vice versa) meant that theinstance closing the last dialog had nothing to restore, so
aria-hiddenstayed on the pagecontent after all dialogs were closed, leaving the app inaccessible to assistive technology.
This change shares the map of hidden elements with the parent
Dialog, following the samepattern already used for
openDialogsandafterAllClosed. A unit test covering theparent/child scenario was added; it fails without the fix.
Fixes #30028