Skip to content

build: update octokit monorepo (major) - #3946

Open
angular-robot wants to merge 1 commit into
angular:mainfrom
angular-robot:ng-renovate/major-octokit-monorepo
Open

build: update octokit monorepo (major)#3946
angular-robot wants to merge 1 commit into
angular:mainfrom
angular-robot:ng-renovate/major-octokit-monorepo

Conversation

@angular-robot

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@octokit/openapi-types (source) 28.0.029.0.1 age adoption passing confidence
@octokit/types 17.0.018.0.0 age adoption passing confidence

  • If you want to rebase/retry this PR, check this box

Release Notes

octokit/openapi-types.ts (@​octokit/openapi-types)

v29.0.1

Compare Source

Bug Fixes

v29.0.0

Compare Source

What's Changed
New Endpoints
  • GET /agents/repos/{owner}/{repo}/tasks
  • POST /agents/repos/{owner}/{repo}/tasks
  • GET /agents/repos/{owner}/{repo}/tasks/{task_id}
  • GET /agents/tasks
  • GET /agents/tasks/{task_id}
  • GET /enterprises/{enterprise}/actions/oidc/customization/properties/repo
  • POST /enterprises/{enterprise}/actions/oidc/customization/properties/repo
  • DELETE /enterprises/{enterprise}/actions/oidc/customization/properties/repo/{custom_property_name}
  • GET /enterprises/{enterprise}/copilot/metrics/reports/enterprise-1-day
  • GET /enterprises/{enterprise}/copilot/metrics/reports/enterprise-28-day/latest
  • GET /enterprises/{enterprise}/copilot/metrics/reports/repos-1-day
  • GET /enterprises/{enterprise}/copilot/metrics/reports/user-teams-1-day
  • GET /enterprises/{enterprise}/copilot/metrics/reports/users-1-day
  • GET /enterprises/{enterprise}/copilot/metrics/reports/users-28-day/latest
  • PUT /enterprises/{enterprise}/copilot/policies/coding_agent
  • POST /enterprises/{enterprise}/copilot/policies/coding_agent/organizations
  • DELETE /enterprises/{enterprise}/copilot/policies/coding_agent/organizations
  • GET /enterprises/{enterprise}/dependabot/repository-access
  • PATCH /enterprises/{enterprise}/dependabot/repository-access
  • PUT /enterprises/{enterprise}/dependabot/repository-access/default-level
  • GET /organizations/{org}/settings/billing/ai_credit/usage
  • GET /orgs/{org}/actions/oidc/customization/properties/repo
  • POST /orgs/{org}/actions/oidc/customization/properties/repo
  • DELETE /orgs/{org}/actions/oidc/customization/properties/repo/{custom_property_name}
  • GET /orgs/{org}/agents/secrets
  • GET /orgs/{org}/agents/secrets/public-key
  • GET /orgs/{org}/agents/secrets/{secret_name}
  • PUT /orgs/{org}/agents/secrets/{secret_name}
  • DELETE /orgs/{org}/agents/secrets/{secret_name}
  • GET /orgs/{org}/agents/secrets/{secret_name}/repositories
  • PUT /orgs/{org}/agents/secrets/{secret_name}/repositories
  • PUT /orgs/{org}/agents/secrets/{secret_name}/repositories/{repository_id}
  • DELETE /orgs/{org}/agents/secrets/{secret_name}/repositories/{repository_id}
  • GET /orgs/{org}/agents/variables
  • POST /orgs/{org}/agents/variables
  • GET /orgs/{org}/agents/variables/{name}
  • DELETE /orgs/{org}/agents/variables/{name}
  • PATCH /orgs/{org}/agents/variables/{name}
  • GET /orgs/{org}/agents/variables/{name}/repositories
  • PUT /orgs/{org}/agents/variables/{name}/repositories
  • PUT /orgs/{org}/agents/variables/{name}/repositories/{repository_id}
  • DELETE /orgs/{org}/agents/variables/{name}/repositories/{repository_id}
  • POST /orgs/{org}/artifacts/metadata/deployment-record/cluster/{cluster}/jobs
  • GET /orgs/{org}/artifacts/metadata/deployment-record/cluster/{cluster}/jobs/{job_id}
  • GET /orgs/{org}/copilot-spaces
  • POST /orgs/{org}/copilot-spaces
  • GET /orgs/{org}/copilot-spaces/{space_number}
  • PUT /orgs/{org}/copilot-spaces/{space_number}
  • DELETE /orgs/{org}/copilot-spaces/{space_number}
  • GET /orgs/{org}/copilot-spaces/{space_number}/collaborators
  • POST /orgs/{org}/copilot-spaces/{space_number}/collaborators
  • PUT /orgs/{org}/copilot-spaces/{space_number}/collaborators/{actor_type}/{actor_identifier}
  • DELETE /orgs/{org}/copilot-spaces/{space_number}/collaborators/{actor_type}/{actor_identifier}
  • GET /orgs/{org}/copilot-spaces/{space_number}/resources
  • POST /orgs/{org}/copilot-spaces/{space_number}/resources
  • GET /orgs/{org}/copilot-spaces/{space_number}/resources/{space_resource_id}
  • PUT /orgs/{org}/copilot-spaces/{space_number}/resources/{space_resource_id}
  • DELETE /orgs/{org}/copilot-spaces/{space_number}/resources/{space_resource_id}
  • GET /orgs/{org}/copilot/coding-agent/permissions
  • PUT /orgs/{org}/copilot/coding-agent/permissions
  • GET /orgs/{org}/copilot/coding-agent/permissions/repositories
  • PUT /orgs/{org}/copilot/coding-agent/permissions/repositories
  • PUT /orgs/{org}/copilot/coding-agent/permissions/repositories/{repository_id}
  • DELETE /orgs/{org}/copilot/coding-agent/permissions/repositories/{repository_id}
  • GET /orgs/{org}/copilot/content_exclusion
  • PUT /orgs/{org}/copilot/content_exclusion
  • GET /orgs/{org}/copilot/metrics/reports/organization-1-day
  • GET /orgs/{org}/copilot/metrics/reports/organization-28-day/latest
  • GET /orgs/{org}/copilot/metrics/reports/repos-1-day
  • GET /orgs/{org}/copilot/metrics/reports/user-teams-1-day
  • GET /orgs/{org}/copilot/metrics/reports/users-1-day
  • GET /orgs/{org}/copilot/metrics/reports/users-28-day/latest
  • GET /orgs/{org}/dependabot/repository-access
  • PATCH /orgs/{org}/dependabot/repository-access
  • PUT /orgs/{org}/dependabot/repository-access/default-level
  • GET /orgs/{org}/interaction-limits/pulls/creation-cap
  • PATCH /orgs/{org}/interaction-limits/pulls/creation-cap
  • GET /orgs/{org}/issue-fields
  • POST /orgs/{org}/issue-fields
  • DELETE /orgs/{org}/issue-fields/{issue_field_id}
  • PATCH /orgs/{org}/issue-fields/{issue_field_id}
  • POST /orgs/{org}/projectsV2/{project_number}/views
  • GET /orgs/{org}/projectsV2/{project_number}/views/{view_number}/items
  • GET /orgs/{org}/secret-scanning/custom-patterns
  • POST /orgs/{org}/secret-scanning/custom-patterns
  • DELETE /orgs/{org}/secret-scanning/custom-patterns
  • PATCH /orgs/{org}/secret-scanning/custom-patterns/{pattern_id}
  • GET /repos/{owner}/{repo}/actions/concurrency_groups
  • GET /repos/{owner}/{repo}/actions/concurrency_groups/{concurrency_group_name}
  • GET /repos/{owner}/{repo}/actions/runs/{run_id}/concurrency_groups
  • GET /repos/{owner}/{repo}/agents/organization-secrets
  • GET /repos/{owner}/{repo}/agents/organization-variables
  • GET /repos/{owner}/{repo}/agents/secrets
  • GET /repos/{owner}/{repo}/agents/secrets/public-key
  • GET /repos/{owner}/{repo}/agents/secrets/{secret_name}
  • PUT /repos/{owner}/{repo}/agents/secrets/{secret_name}
  • DELETE /repos/{owner}/{repo}/agents/secrets/{secret_name}
  • GET /repos/{owner}/{repo}/agents/variables
  • POST /repos/{owner}/{repo}/agents/variables
  • GET /repos/{owner}/{repo}/agents/variables/{name}
  • DELETE /repos/{owner}/{repo}/agents/variables/{name}
  • PATCH /repos/{owner}/{repo}/agents/variables/{name}
  • GET /repos/{owner}/{repo}/code-quality/findings
  • GET /repos/{owner}/{repo}/code-quality/findings/{finding_number}
  • GET /repos/{owner}/{repo}/code-quality/setup
  • PATCH /repos/{owner}/{repo}/code-quality/setup
  • GET /repos/{owner}/{repo}/copilot/cloud-agent/configuration
  • GET /repos/{owner}/{repo}/dependency-graph/sbom/fetch-report/{sbom_uuid}
  • GET /repos/{owner}/{repo}/dependency-graph/sbom/generate-report
  • GET /repos/{owner}/{repo}/hash-algorithm
  • GET /repos/{owner}/{repo}/interaction-limits/pulls/bypass-list
  • PUT /repos/{owner}/{repo}/interaction-limits/pulls/bypass-list
  • DELETE /repos/{owner}/{repo}/interaction-limits/pulls/bypass-list
  • GET /repos/{owner}/{repo}/interaction-limits/pulls/creation-cap
  • PATCH /repos/{owner}/{repo}/interaction-limits/pulls/creation-cap
  • GET /repos/{owner}/{repo}/issue-types
  • PUT /repos/{owner}/{repo}/issues/comments/{comment_id}/pin
  • DELETE /repos/{owner}/{repo}/issues/comments/{comment_id}/pin
  • GET /repos/{owner}/{repo}/issues/{issue_number}/issue-field-values
  • PUT /repos/{owner}/{repo}/issues/{issue_number}/issue-field-values
  • POST /repos/{owner}/{repo}/issues/{issue_number}/issue-field-values
  • DELETE /repos/{owner}/{repo}/issues/{issue_number}/issue-field-values/{issue_field_id}
  • GET /repos/{owner}/{repo}/issues/{issue_number}/suggestions
  • POST /repos/{owner}/{repo}/issues/{issue_number}/suggestions/{suggestion_id}/approve
  • POST /repos/{owner}/{repo}/issues/{issue_number}/suggestions/{suggestion_id}/dismiss
  • PUT /repos/{owner}/{repo}/pulls/{pull_number}/merge-async
  • GET /repos/{owner}/{repo}/pulls/{pull_number}/merge-async/{uuid}
  • GET /repos/{owner}/{repo}/secret-scanning/custom-patterns
  • POST /repos/{owner}/{repo}/secret-scanning/custom-patterns
  • DELETE /repos/{owner}/{repo}/secret-scanning/custom-patterns
  • PATCH /repos/{owner}/{repo}/secret-scanning/custom-patterns/{pattern_id}
  • GET /repos/{owner}/{repo}/stacks
  • POST /repos/{owner}/{repo}/stacks
  • GET /repos/{owner}/{repo}/stacks/{stack_number}
  • POST /repos/{owner}/{repo}/stacks/{stack_number}/add
  • POST /repos/{owner}/{repo}/stacks/{stack_number}/unstack
  • GET /repos/{owner}/{repo}/stargazers/count
  • POST /users/{user_id}/projectsV2/{project_number}/views
  • GET /users/{username}/copilot-spaces
  • POST /users/{username}/copilot-spaces
  • GET /users/{username}/copilot-spaces/{space_number}
  • PUT /users/{username}/copilot-spaces/{space_number}
  • DELETE /users/{username}/copilot-spaces/{space_number}
  • GET /users/{username}/copilot-spaces/{space_number}/collaborators
  • POST /users/{username}/copilot-spaces/{space_number}/collaborators
  • PUT /users/{username}/copilot-spaces/{space_number}/collaborators/{actor_type}/{actor_identifier}
  • DELETE /users/{username}/copilot-spaces/{space_number}/collaborators/{actor_type}/{actor_identifier}
  • GET /users/{username}/copilot-spaces/{space_number}/resources
  • POST /users/{username}/copilot-spaces/{space_number}/resources
  • GET /users/{username}/copilot-spaces/{space_number}/resources/{space_resource_id}
  • PUT /users/{username}/copilot-spaces/{space_number}/resources/{space_resource_id}
  • DELETE /users/{username}/copilot-spaces/{space_number}/resources/{space_resource_id}
  • GET /users/{username}/projectsV2/{project_number}/views/{view_number}/items
  • GET /users/{username}/settings/billing/ai_credit/usage
  • POST /organizations/{org}/settings/billing/budgets
Deprecations
  • GET /assignments/{assignment_id}/grades
  • GET /classrooms
  • GET /classrooms/{classroom_id}
  • GET /classrooms/{classroom_id}/assignments
  • GET /assignments/{assignment_id}
  • GET /assignments/{assignment_id}/accepted_assignments
BREAKING CHANGES
Deleted endpoints
  • GET /organizations/{org}/dependabot/repository-access
  • PATCH /organizations/{org}/dependabot/repository-access
  • PUT /organizations/{org}/dependabot/repository-access/default-level
  • GET /organizations/{org}/org-properties/values
  • PATCH /organizations/{org}/org-properties/values
  • GET /orgs/{org}/copilot/metrics
  • GET /orgs/{org}/team/{team_slug}/copilot/metrics
  • GET /orgs/{org}/teams/{team_slug}/discussions
  • POST /orgs/{org}/teams/{team_slug}/discussions
  • GET /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}
  • DELETE /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}
  • PATCH /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}
  • GET /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}/comments
  • POST /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}/comments
  • GET /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}/comments/{comment_number}
  • DELETE /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}/comments/{comment_number}
  • PATCH /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}/comments/{comment_number}
  • GET /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}/comments/{comment_number}/reactions
  • POST /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}/comments/{comment_number}/reactions
  • DELETE /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}/comments/{comment_number}/reactions/{reaction_id}
  • GET /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}/reactions
  • POST /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}/reactions
  • DELETE /orgs/{org}/teams/{team_slug}/discussions/{discussion_number}/reactions/{reaction_id}
  • GET /repos/{owner}/{repo}/tags/protection
  • POST /repos/{owner}/{repo}/tags/protection
  • DELETE /repos/{owner}/{repo}/tags/protection/{tag_protection_id}
  • GET /teams/{team_id}/discussions
  • POST /teams/{team_id}/discussions
  • GET /teams/{team_id}/discussions/{discussion_number}
  • DELETE /teams/{team_id}/discussions/{discussion_number}
  • PATCH /teams/{team_id}/discussions/{discussion_number}
  • GET /teams/{team_id}/discussions/{discussion_number}/comments
  • POST /teams/{team_id}/discussions/{discussion_number}/comments
  • GET /teams/{team_id}/discussions/{discussion_number}/comments/{comment_number}
  • DELETE /teams/{team_id}/discussions/{discussion_number}/comments/{comment_number}
  • PATCH /teams/{team_id}/discussions/{discussion_number}/comments/{comment_number}
  • GET /teams/{team_id}/discussions/{discussion_number}/comments/{comment_number}/reactions
  • POST /teams/{team_id}/discussions/{discussion_number}/comments/{comment_number}/reactions
  • GET /teams/{team_id}/discussions/{discussion_number}/reactions
  • POST /teams/{team_id}/discussions/{discussion_number}/reactions

Full Changelog: octokit/openapi-types.ts@v28.0.0...v29.0.0

octokit/types.ts (@​octokit/types)

v18.0.0

Compare Source

Features
  • update endpoints with major additions as of 2026-08-24 (#​723) (c4b93f2)
BREAKING CHANGES
  • remove deprecated endpoints

See associated pull request for more information.
@angular-robot angular-robot added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] labels Aug 31, 2026
@angular-robot

Copy link
Copy Markdown
Contributor Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: undefined
Command failed: pnpm update-generated-files
$ pnpm ng-dev misc update-generated-files
$ bash ./tools/local-dev.sh misc update-generated-files
Computing main repo mapping: 
Loading: 
Loading: 1 packages loaded
Analyzing: target //ng-dev:npm_package (2 packages loaded, 0 targets configured)
Analyzing: target //ng-dev:npm_package (2 packages loaded, 0 targets configured)

Analyzing: target //ng-dev:npm_package (478 packages loaded, 7629 targets configured)

INFO: Analyzed target //ng-dev:npm_package (615 packages loaded, 8131 targets configured).
INFO: Found 1 target...
Target //ng-dev:npm_package up-to-date:
  dist/bin/ng-dev/npm_package
INFO: Elapsed time: 2.551s, Critical Path: 0.06s
INFO: 1 process: 1771 action cache hit, 1 internal.
INFO: Build completed successfully, 1 total action
ng-dev misc update-generated-files

Automatically discover all bazel generated file targets and update them.

Options:
  --version  Show version number                                                                               [boolean]
  --help     Show help                                                                                         [boolean]

Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Analyzing: 20 targets (0 packages loaded, 0 targets configured)
Analyzing: 20 targets (0 packages loaded, 0 targets configured)

Analyzing: 20 targets (88 packages loaded, 413 targets configured)

INFO: Analyzed 20 targets (93 packages loaded, 554 targets configured).
[1,521 / 1,637] TsValidateOptions github-actions/unified-status-check/lib_params.validation; 0s processwrapper-sandbox ... (4 actions, 3 running)
[1,538 / 1,637] Bundling Javascript ../../../github-actions/saucelabs/index.ts [esbuild]; 1s processwrapper-sandbox ... (4 actions, 3 running)
[1,570 / 1,637] TsValidateOptions github-actions/saucelabs/saucelabs_params.validation; 0s processwrapper-sandbox ... (4 actions, 3 running)
[1,585 / 1,637] Bundling Javascript ../../../github-actions/google-internal-tests/lib/main.ts [esbuild]; 0s processwrapper-sandbox ... (4 actions, 3 running)
[1,587 / 1,637] Bundling Javascript ../../../.github/local-actions/update-models/lib/main.ts [esbuild]; 1s processwrapper-sandbox ... (4 actions, 3 running)
[1,593 / 1,637] Bundling Javascript ../../../.github/local-actions/update-models/lib/main.ts [esbuild]; 2s processwrapper-sandbox ... (4 actions running)
[1,598 / 1,637] Compiling TS: @@//.github/local-actions/labels-sync:lib; 1s worker ... (4 actions running)
[1,602 / 1,637] Bundling Javascript ../../../github-actions/unified-status-check/lib/main.ts [esbuild]; 1s processwrapper-sandbox ... (4 actions, 3 running)
[1,609 / 1,637] Bundling Javascript ../../../.github/local-actions/labels-sync/lib/main.ts [esbuild]; 1s processwrapper-sandbox ... (4 actions, 3 running)
[1,613 / 1,637] Bundling Javascript ../../../github-actions/branch-manager/lib/main.ts [esbuild]; 1s processwrapper-sandbox ... (4 actions, 3 running)
[1,620 / 1,637] Compiling TS: @@//.github/local-actions/branch-manager:lib; 0s worker ... (4 actions, 3 running)
[1,622 / 1,637] Bundling Javascript ../../../github-actions/post-approval-changes/lib/main.ts [esbuild]; 1s processwrapper-sandbox ... (4 actions running)
[1,628 / 1,637] Bundling Javascript ../../../.github/local-actions/branch-manager/lib/main.ts [esbuild]; 2s processwrapper-sandbox ... (4 actions running)
[1,630 / 1,637] Bundling Javascript ../../../github-actions/release/publish/lib/main.ts [esbuild]; 1s processwrapper-sandbox ... (3 actions running)
[1,633 / 1,637] Compiling TS: @@//github-actions/labeling/issue:lib; 2s worker ... (2 actions, 1 running)
ERROR: /tmp/renovate/repos/github/angular/dev-infra/github-actions/labeling/issue/BUILD.bazel:5:11: Compiling TS: @@//github-actions/labeling/issue:lib failed: (Exit 1): worker_vanilla_ts failed: error executing TsProject command (from target //github-actions/labeling/issue:lib) bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/rules_angular+/src/worker/worker_vanilla_ts_/worker_vanilla_ts --bazel-bindir bazel-out/k8-fastbuild/bin ... (remaining 1 argument skipped)
Pre-emit diagnostics:

github-actions/labeling/issue/lib/issue-labeling.ts:202:9 - error TS2322: Type '{ id: number; node_id: string; url: string; repository_url: string; labels_url: string; comments_url: string; events_url: string; html_url: string; number: number; state: string; state_reason?: "completed" | ... 4 more ... | undefined; ... 27 more ...; issue_field_values?: { ...; }[] | undefined; }' is not assignable to type '{ id: number | bigint; node_id: string; url: string; repository_url: string; labels_url: string; comments_url: string; events_url: string; html_url: string; number: number; state: string; state_reason?: "completed" | ... 4 more ... | undefined; ... 28 more ...; issue_field_values?: { ...; }[] | undefined; }'.
  Types of property 'assignees' are incompatible.
    Type '{ name?: string | null | undefined; email?: string | null | undefined; login: string; id: number; node_id: string; avatar_url: string; gravatar_id: string | null; url: string; html_url: string; ... 12 more ...; user_view_type?: string | undefined; }[] | null | undefined' is not assignable to type '{ name?: string | null | undefined; email?: string | null | undefined; login: string; id: number | bigint; node_id: string; avatar_url: string; gravatar_id: string | null; url: string; ... 13 more ...; user_view_type?: string | undefined; }[] | undefined'.
      Type 'null' is not assignable to type '{ name?: string | null | undefined; email?: string | null | undefined; login: string; id: number | bigint; node_id: string; avatar_url: string; gravatar_id: string | null; url: string; ... 13 more ...; user_view_type?: string | undefined; }[] | undefined'.

202         this.issueData = resp.data;
            ~~~~~~~~~~~~~~

ERROR: /tmp/renovate/repos/github/angular/dev-infra/github-actions/labeling/issue/BUILD.bazel:55:19 Bundling Javascript ../../../github-actions/labeling/issue/lib/main.ts [esbuild] failed: (Exit 1): worker_vanilla_ts failed: error executing TsProject command (from target //github-actions/labeling/issue:lib) bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/rules_angular+/src/worker/worker_vanilla_ts_/worker_vanilla_ts --bazel-bindir bazel-out/k8-fastbuild/bin ... (remaining 1 argument skipped)
INFO: Elapsed time: 18.375s, Critical Path: 4.45s
INFO: 540 processes: 237 action cache hit, 334 internal, 187 processwrapper-sandbox, 19 worker.
ERROR: Build did NOT complete successfully

Exit code: 1.
Writing full log to /tmp/renovate/repos/github/angular/dev-infra/.ng-dev.err-1788159337663.log

@angular-robot angular-robot added area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] labels Aug 31, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @octokit/types dependency from 17.0.0 to 18.0.0 and @octokit/openapi-types from 28.0.0 to 29.0.1 across several package files and the lockfile. The review feedback correctly points out that upgrading these packages independently while other Octokit dependencies (such as @octokit/rest) remain locked to older versions will introduce TypeScript type mismatches and compilation errors. It is recommended to revert these upgrades and keep @octokit/types at 17.0.0 and @octokit/openapi-types at 28.0.0 to maintain compatibility.

"@actions/github": "9.1.1",
"@octokit/rest": "22.0.1",
"@octokit/types": "17.0.0",
"@octokit/types": "18.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating @octokit/types to 18.0.0 while @octokit/rest is still locked to @octokit/types 17.0.0 will cause TypeScript type mismatches. It is recommended to keep @octokit/types at 17.0.0 to maintain compatibility.

Suggested change
"@octokit/types": "18.0.0",
"@octokit/types": "17.0.0",

"@actions/github": "9.1.1",
"@octokit/rest": "22.0.1",
"@octokit/types": "17.0.0",
"@octokit/types": "18.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating @octokit/types to 18.0.0 while @octokit/rest is still locked to @octokit/types 17.0.0 will cause TypeScript type mismatches. It is recommended to keep @octokit/types at 17.0.0 to maintain compatibility.

Suggested change
"@octokit/types": "18.0.0",
"@octokit/types": "17.0.0",

"micromatch": "^4.0.8",
"typed-graphqlify": "3.1.6",
"@octokit/openapi-types": "28.0.0",
"@octokit/openapi-types": "29.0.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating @octokit/openapi-types to 29.0.1 while the rest of the Octokit ecosystem in this project depends on 28.0.0 can lead to type mismatches. It is recommended to keep @octokit/openapi-types at 28.0.0 for compatibility.

Suggested change
"@octokit/openapi-types": "29.0.1",
"@octokit/openapi-types": "28.0.0",

"@actions/github": "9.1.1",
"@octokit/rest": "22.0.1",
"@octokit/types": "17.0.0",
"@octokit/types": "18.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating @octokit/types to 18.0.0 while @octokit/rest is still locked to @octokit/types 17.0.0 will cause TypeScript type mismatches. It is recommended to keep @octokit/types at 17.0.0 to maintain compatibility.

Suggested change
"@octokit/types": "18.0.0",
"@octokit/types": "17.0.0",

"@octokit/graphql-schema": "15.26.1",
"@octokit/rest": "22.0.1",
"@octokit/types": "17.0.0",
"@octokit/types": "18.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating @octokit/types to 18.0.0 while @octokit/rest is still locked to @octokit/types 17.0.0 will cause TypeScript type mismatches. It is recommended to keep @octokit/types at 17.0.0 to maintain compatibility.

Suggested change
"@octokit/types": "18.0.0",
"@octokit/types": "17.0.0",

Comment thread ng-dev/package.json
"@octokit/graphql-schema": "15.26.1",
"@octokit/graphql": "9.0.4",
"@octokit/openapi-types": "28.0.0",
"@octokit/openapi-types": "29.0.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating @octokit/openapi-types to 29.0.1 while @octokit/types is kept at 17.0.0 (which depends on @octokit/openapi-types 28.0.0) will cause type mismatches. It is recommended to keep @octokit/openapi-types at 28.0.0 to maintain compatibility with the rest of the Octokit ecosystem.

Suggested change
"@octokit/openapi-types": "29.0.1",
"@octokit/openapi-types": "28.0.0",

Comment thread ng-dev/package.json
"@octokit/request-error": "7.1.1",
"@octokit/rest": "22.0.1",
"@octokit/types": "17.0.0",
"@octokit/types": "18.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating @octokit/types to 18.0.0 while other Octokit packages (such as @octokit/rest and @octokit/plugin-rest-endpoint-methods) are still locked to @octokit/types 17.0.0 will introduce duplicate type definitions and cause TypeScript compilation errors due to type mismatches. It is recommended to keep @octokit/types at 17.0.0 until the rest of the Octokit ecosystem in this project is updated to support v18.

Suggested change
"@octokit/types": "18.0.0",
"@octokit/types": "17.0.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant