build: update octokit monorepo (major) - #3946
Conversation
See associated pull request for more information.
|
There was a problem hiding this comment.
Code Review
This pull request updates the @octokit/types dependency from 17.0.0 to 18.0.0 and @octokit/openapi-types from 28.0.0 to 29.0.1 across several package files and the lockfile. The review feedback correctly points out that upgrading these packages independently while other Octokit dependencies (such as @octokit/rest) remain locked to older versions will introduce TypeScript type mismatches and compilation errors. It is recommended to revert these upgrades and keep @octokit/types at 17.0.0 and @octokit/openapi-types at 28.0.0 to maintain compatibility.
| "@actions/github": "9.1.1", | ||
| "@octokit/rest": "22.0.1", | ||
| "@octokit/types": "17.0.0", | ||
| "@octokit/types": "18.0.0", |
There was a problem hiding this comment.
| "@actions/github": "9.1.1", | ||
| "@octokit/rest": "22.0.1", | ||
| "@octokit/types": "17.0.0", | ||
| "@octokit/types": "18.0.0", |
There was a problem hiding this comment.
| "micromatch": "^4.0.8", | ||
| "typed-graphqlify": "3.1.6", | ||
| "@octokit/openapi-types": "28.0.0", | ||
| "@octokit/openapi-types": "29.0.1", |
There was a problem hiding this comment.
Updating @octokit/openapi-types to 29.0.1 while the rest of the Octokit ecosystem in this project depends on 28.0.0 can lead to type mismatches. It is recommended to keep @octokit/openapi-types at 28.0.0 for compatibility.
| "@octokit/openapi-types": "29.0.1", | |
| "@octokit/openapi-types": "28.0.0", |
| "@actions/github": "9.1.1", | ||
| "@octokit/rest": "22.0.1", | ||
| "@octokit/types": "17.0.0", | ||
| "@octokit/types": "18.0.0", |
There was a problem hiding this comment.
| "@octokit/graphql-schema": "15.26.1", | ||
| "@octokit/rest": "22.0.1", | ||
| "@octokit/types": "17.0.0", | ||
| "@octokit/types": "18.0.0", |
There was a problem hiding this comment.
| "@octokit/graphql-schema": "15.26.1", | ||
| "@octokit/graphql": "9.0.4", | ||
| "@octokit/openapi-types": "28.0.0", | ||
| "@octokit/openapi-types": "29.0.1", |
There was a problem hiding this comment.
Updating @octokit/openapi-types to 29.0.1 while @octokit/types is kept at 17.0.0 (which depends on @octokit/openapi-types 28.0.0) will cause type mismatches. It is recommended to keep @octokit/openapi-types at 28.0.0 to maintain compatibility with the rest of the Octokit ecosystem.
| "@octokit/openapi-types": "29.0.1", | |
| "@octokit/openapi-types": "28.0.0", |
| "@octokit/request-error": "7.1.1", | ||
| "@octokit/rest": "22.0.1", | ||
| "@octokit/types": "17.0.0", | ||
| "@octokit/types": "18.0.0", |
There was a problem hiding this comment.
Updating @octokit/types to 18.0.0 while other Octokit packages (such as @octokit/rest and @octokit/plugin-rest-endpoint-methods) are still locked to @octokit/types 17.0.0 will introduce duplicate type definitions and cause TypeScript compilation errors due to type mismatches. It is recommended to keep @octokit/types at 17.0.0 until the rest of the Octokit ecosystem in this project is updated to support v18.
| "@octokit/types": "18.0.0", | |
| "@octokit/types": "17.0.0", |
This PR contains the following updates:
28.0.0→29.0.117.0.0→18.0.0Release Notes
octokit/openapi-types.ts (@octokit/openapi-types)
v29.0.1Compare Source
Bug Fixes
v29.0.0Compare Source
What's Changed
New Endpoints
Deprecations
BREAKING CHANGES
Deleted endpoints
Full Changelog: octokit/openapi-types.ts@v28.0.0...v29.0.0
octokit/types.ts (@octokit/types)
v18.0.0Compare Source
Features
BREAKING CHANGES