fix(tui): clear answer editing state when selecting other options - #44240
Open
aniruddhaadak80 wants to merge 1 commit into
Open
fix(tui): clear answer editing state when selecting other options#44240aniruddhaadak80 wants to merge 1 commit into
aniruddhaadak80 wants to merge 1 commit into
Conversation
Correct root-cause analysis: mouse paths call Details:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #44192
Type of change
What does this PR do?
Mouse handlers call
selectOption()/selectTab()directly and bypass theenabled: !store.editinggate on the keybindings. So after selecting "Type your own answer" (editing mode), clicking a preset option (or another question tab) picks it but leavesstore.editingstuck ontrue. At the confirm tab both binding sets then refuse Return - the editing set requires!confirm()and the normal set requires!store.editing- so the answers can never be submitted.This clears
editingwhen a preset option is picked or the tab changes. Selecting the custom row still enters edit mode as before; keyboard-only flows are unchanged since those keys are already gated off while editing.How did you verify your code works?
bun run typecheckclean inpackages/tui; existing tui test suite shows no new failures.Screenshots / recordings
Not a visual UI change.
Checklist