Repository navigation
Distributes compaction coordination across managers - #6324
Open
keith-turner wants to merge 27 commits into
Open
keith-turner wants to merge 27 commits into
keith-turner wants to merge 27 commits into
Conversation
For an overview of how this works see the javadoc in CompactionCoordinator.
Contributor
Author
dlmarion
reviewed
Apr 20, 2026
dlmarion
reviewed
Apr 20, 2026
dlmarion
reviewed
Apr 20, 2026
| sleepTime = maxSleepTime; | ||
| } | ||
|
|
||
| UtilWaitThread.sleep(sleepTime); |
Contributor
There was a problem hiding this comment.
We might need a property here like the TABLE_SUSPEND_DURATION, but for Coordinators. There is a case where we don't want to be too responsive to a Manager going away and coming back. Bouncing the Manager sometimes clears up some state issues. I would think that we only want to recompute the group assignments if the number of compaction groups has changed or the number of managers has changed, and then only after some suspend duration.
Contributor
Author
There was a problem hiding this comment.
That makes sense. For our ITs we want this to be really responsive, but on a real system having it take its time when there is volatility would probably be good.
…n/CoordinatorLocationsFactory.java Co-authored-by: Dave Marion <dlmarion@apache.org>
keith-turner
commented
Oct 27, 2026
revert changes in 9af4fdd as it broke clearing uneeded compaction jobs. CompactionPriorityQueueMetricsIT.testCompactionQueueClearedWhenNotNeeded() was failing
Contributor
Author
|
All ITs are passing for b54ed2a |
dlmarion
reviewed
Nov 5, 2026
…ction/coordinator/CompactionCoordinator.java Co-authored-by: Dave Marion <dlmarion@apache.org>
…ction/coordinator/CompactionCoordinator.java Co-authored-by: Dave Marion <dlmarion@apache.org>
…ction/coordinator/CompactionCoordinator.java Co-authored-by: Dave Marion <dlmarion@apache.org>
…ction/coordinator/CompactionCoordinator.java Co-authored-by: Dave Marion <dlmarion@apache.org>
…ction/CompactionJobClient.java Co-authored-by: Dave Marion <dlmarion@apache.org>
…ction/CompactionJobClient.java Co-authored-by: Dave Marion <dlmarion@apache.org>
…pactionIT.java Co-authored-by: Dave Marion <dlmarion@apache.org>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an overview of how this works see the javadoc in CompactionCoordinator.