Repository navigation
Validate properties on load/upgrade instead of on read - #6648
Open
DomGarguilo wants to merge 2 commits into
Open
DomGarguilo wants to merge 2 commits into
DomGarguilo wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5
keith-turner
approved these changes
Nov 13, 2026
Contributor
|
Was wondering if ZooBasedConfiguration.getParent() could be removed after these changes. Looked into and it seems like it may only be used by tests after the changes, so can not remove it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6634
Removes prop validation on read from
SystemConfiguration,ResourceGroupConfiguration, andSiteConfiguration. Bad values no longer silently fall back to the parent value which matches how the other config classes already work.Since reads no longer validate, resource group props are now validated on load and during upgrade which now matches how system, namespace and table props behave.
One behavior change is an invalid value that is in ZooKeeper is now used as-is instead of being replaced by the parent value.