[CALCITE-7269] SqlValidator throws exception if lambda parameter is struct - #5190
Conversation
…truct Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
|
|
Maybe the Jira link in the PR description is a typo? It looks like it should point to CALCITE-7269 rather than CALCITE-7629. |
|
Thanks, I fixed the link. |
| .build(); | ||
| restructured = RelOptUtil.copyRelHints(flattened, restructured); | ||
| // REVIEW jvs 23-Mar-2005: How do we make sure that this | ||
| // implementation stays in Java? Fennel can't handle |
There was a problem hiding this comment.
What is Fennel ? Does it still exist ?
There was a problem hiding this comment.
Fennel has been gone for more than a decade as far as I know
There was a problem hiding this comment.
I don't recall how this comment got here, I will just remove it.
dssysolyatin
left a comment
dssysolyatin
left a comment
There was a problem hiding this comment.
Thanks @mihaibudiu! Looks good to me
|
Since @dssysolyatin approved and only a small change is necessary, I will amend the commit instead of pushing a new one |
mihaibudiu
added
the
LGTM-will-merge-soon
3 participants
Jira Link
CALCITE-7269
Changes Proposed
There are several small issues in various parts of the stack.
I have also cleaned-up a bit the
RelStructuredTypeFlattener, whose JavaDoc mentioned a bunch of plan objects which no longer exists. (We are running our compiler without the type flattener, I suspect it could actually be deprecated; it may not work correctly with arbitrary lambdas that manipulate ROW types; I added some warnings in the JavaDoc).