Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13788 +/- ##
=========================================
Coverage 19.91% 19.91%
- Complexity 20198 20203 +5
=========================================
Files 6373 6373
Lines 577230 577236 +6
Branches 70696 70696
=========================================
+ Hits 114936 114967 +31
+ Misses 449736 449703 -33
- Partials 12558 12566 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
…steners and ensuring downstream listeners are invoked. Add tests to verify behavior with null hostId and exception handling.
Damans227
force-pushed
the
power-state-sync-npe-resilience
branch
from
October 5, 2026 13:40
90ce7bd to
57a5ff8
Compare
Collaborator
Author
|
@nvazquez can you review this one? its rebased on main and the conflicts are fixed |
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
3 open issues
Exceptionwill also swallowInterruptedException, which can clear or ignore interrupt… · NewhostIdis null (the method parameter vsvm.getHostId()vs… · NewMockito.any()for theCommand[]argument, which is less specific than… · New
What changed in this PR
Improves resilience in AgentManagerImpl.handleCommands so a single misbehaving listener can’t prevent subsequent listeners (e.g., ping) from running, and fixes a DAO partial-select projection that omitted hostId, leading to incorrect VM host reporting.
Changes:
- Wrap each
Listener.processCommandsinvocation inhandleCommandswith try/catch and log-and-continue on failures. - Fix trace logging to report the listener type rather than the
Pairwrapper. - Include
hostIdinVMInstanceDaoImpl.IdsPowerStateSelectSearchand add tests covering the null-hostId projection case.
| File | Description |
|---|---|
| engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java | Adds exception isolation per listener and corrects trace logging to avoid starving downstream listeners. |
| engine/orchestration/src/test/java/com/cloud/agent/manager/AgentManagerImplTest.java | Adds tests ensuring throwing listeners don’t abort the listener loop and downstream listeners still run. |
| engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java | Fixes partial-select projection by adding hostId to selected fields. |
| engine/schema/src/test/java/com/cloud/vm/dao/VMInstanceDaoImplTest.java | Adds regression tests for update-power-state behavior when hostId is null due to partial-select projection. |
Review effort: Lite
Comment on lines
+463
to
+469
| try { | ||
| final boolean processed = listener.second().processCommands(attache.getId(), sequence, cmds); | ||
| logger.trace("SeqA {}-{}: {} by {}", attache.getId(), sequence, (processed ? "processed" : "not processed"), listener.second().getClass()); | ||
| } catch (final Exception e) { | ||
| logger.warn("Listener {} threw an exception processing commands for agent {} seq {}; continuing to next listener", | ||
| listener.second().getClass().getName(), attache.getId(), sequence, e); | ||
| } |
Comment on lines
+215
to
+217
| * hostId (the default from setUp), which is what happens when the row was loaded through | ||
| * a partial-select projection that doesn't include hostId. isPowerStateInSyncWithInstanceState | ||
| * must not NPE on the null hostId, and must still detect the state is out-of-sync. |
Comment on lines
+185
to
+189
| Mockito.when(throwingListener.processCommands(Mockito.anyLong(), Mockito.anyLong(), Mockito.any())) | ||
| .thenThrow(new RuntimeException("simulated NPE from power-state sync")); | ||
|
|
||
| Listener goodListener = Mockito.mock(Listener.class); | ||
| Mockito.when(goodListener.processCommands(Mockito.anyLong(), Mockito.anyLong(), Mockito.any())) |
Copilot stopped reviewing on behalf of
nvazquez due to an error
November 9, 2026 17:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If one listener in
handleCommandsthrows, the whole loop stops and every listener after it never runs. This can starvepingBy()and cause fake ping timeouts.This wraps each listener call in a try/catch, so one bad listener just logs a warning and the rest still run. Also fixed a trace log nearby that was logging the wrong class (the
Pairwrapper instead of the listener).Also added the missing
hostIdfield toIdsPowerStateSelectSearch. Without it, VMs loaded through that path always showed a null host, even when they had one. Not a crash, just a wrong log message.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
Added tests: a throwing listener doesn't block the next one, and existing behavior with only successful listeners is unchanged. Also added tests for the null-hostId case, which had no coverage before.