Repository navigation
use ConfigKeys for alert, storage, guest network and hidden settings - #14473
Open
DaanHoogland wants to merge 4 commits into
Open
DaanHoogland wants to merge 4 commits into
DaanHoogland wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## ghi10752-config-foundation #14473 +/- ##
=============================================================
Coverage 20.70% 20.70%
- Complexity 21727 21728 +1
=============================================================
Files 6508 6508
Lines 591042 591003 -39
Branches 72448 72435 -13
=============================================================
+ Hits 122355 122359 +4
+ Misses 455414 455380 -34
+ Partials 13273 13264 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 25.80% |
| Branch coverage | 20.07% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
DaanHoogland
force-pushed
the
ghi10752-config-core-1
branch
from
October 23, 2026 14:58
69d0a74 to
217fb98
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
DaanHoogland
force-pushed
the
ghi10752-config-core-1
branch
from
October 27, 2026 17:08
217fb98 to
ee7248d
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
The usage server has no ConfigDepot, so ConfigKey.value() only returns the built-in defaults there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DaanHoogland
force-pushed
the
ghi10752-config-core-1
branch
from
October 28, 2026 07:51
ee7248d to
3664fd4
Compare
|
JoaoJandre
reviewed
Oct 29, 2026
Comment on lines
-1553
to
-1555
| if (templateOnPrimary == null) { | ||
| throw new CloudRuntimeException(String.format("Failed to create template %s on primary storage: %s", srcTemplateInfo, destPrimaryDataStore)); | ||
| } |
Comment on lines
+1875
to
1876
| if (ManagementServer.CheckPodCIDRs.value()) { | ||
| checkPodCidrSubnets(zone.getId(), podId, cidr); |
Contributor
There was a problem hiding this comment.
this will change the behavior, no?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First of five stacked PRs for the call sites that share files too much to be reviewed in parallel: alert, storage, guest network and hidden settings.
Part 7 of 12 of the split of #13884 (phase out the deprecated
Configenum, #10752). Base:ghi10752-config-foundation. Independent of the other PRs based on the foundation, so it can be reviewed and merged in any order relative to them; GitHub retargets it tomainonce the foundation is merged.Size: 41 files, +162/-234.
Split overview: foundation → parallel PRs (account, vpn-vpc, snapshot-usage, event-bus, literals) + stacked core-1 … core-5 → enum-removal (last).
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Local verification: full reactor build (checkstyle included) and the unit tests of every touched module pass on this branch; merging all PRs of the split in any order gives no conflicts and reproduces #13884 plus its fixes.
🤖 Generated with Claude Code