Repository navigation
Conversation
Use a four-byte sliding window so high-bit bytes and overlapping partial matches are found. Add focused regressions and an issue-linked change note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BinaryFunctions.searchQuadcompares signed Java bytes with unsignedInputStream.read()values and drops a partial match when the mismatching byte could start the next match. This can miss a quad containing high-bit bytes or an overlapping prefix.Use a four-byte sliding window to compare the complete sequence. Add regressions for high-bit bytes, overlapping matches, short/non-matching streams, and the stream position after a match. Add an
IMAGING-389change entry.Jira: https://issues.apache.org/jira/browse/IMAGING-389
Validation
BinaryFunctionsTestand fullmvn -q verifypassed locally.mvn) previously passed on the same final file tree; a freshmvn -qrun also passed.Contributor checklist