Repository navigation
Rename three test classes so Surefire runs them - #563
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
FullColorRoundtrip and PixelDensityRoundtrip were split out of RoundtripTest without the Test suffix, and PngWriteForceTrueColorText has a typo in its suffix. None of the names match the default Surefire includes, so their 63 test cases never ran in the build. Rename them to FullColorRoundtripTest, PixelDensityRoundtripTest and PngWriteForceTrueColorTest, matching their siblings such as BitmapRoundtripTest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FullColorRoundtripandPixelDensityRoundtripwere split out ofRoundtripTestwithout theTestsuffix, andPngWriteForceTrueColorTexthas a typo in its suffix. None of these names match the default Surefire includes, so their 63 test cases never ran. This renames them to*Test, likeBitmapRoundtripTest. They all pass, and the defaultmvnbuild passes.Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.