Skip to content

Rename three test classes so Surefire runs them - #563

Open
sharanggupta wants to merge 1 commit into
apache:masterfrom
sharanggupta:run-misnamed-tests
Open

sharanggupta wants to merge 1 commit into
apache:masterfrom
sharanggupta:run-misnamed-tests

Conversation

@sharanggupta

Copy link
Copy Markdown

FullColorRoundtrip and PixelDensityRoundtrip were split out of RoundtripTest without the Test suffix, and PngWriteForceTrueColorText has a typo in its suffix. None of these names match the default Surefire includes, so their 63 test cases never ran. This renames them to *Test, like BitmapRoundtripTest. They all pass, and the default mvn build passes.

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude (Anthropic) helped analyse the issue and draft the change and tests; I reviewed them against the code and ran the build.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

FullColorRoundtrip and PixelDensityRoundtrip were split out of
RoundtripTest without the Test suffix, and PngWriteForceTrueColorText
has a typo in its suffix. None of the names match the default Surefire
includes, so their 63 test cases never ran in the build. Rename them to
FullColorRoundtripTest, PixelDensityRoundtripTest and
PngWriteForceTrueColorTest, matching their siblings such as
BitmapRoundtripTest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant