Repository navigation
Conversation
Preserve complete EXIF fields when the unused next-directory offset is truncated during non-strict classic TIFF parsing. Keep strict and root-directory parsing unchanged, and record a format compliance comment. Add five regression tests covering the reported JPEG, retained EXIF fields, strict rejection, a completed footer, and truncated root rejection. Full default Maven build passes: 1264 tests, zero failures or errors, seven skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imaging.getImageInfo() fails on the JPEG attached to IMAGING-240 because its EXIF subdirectory ends after the last complete entry, without the four-byte next-directory offset. This prevents reading the image information even though the JPEG dimensions are available.
In non-strict classic TIFF parsing, treat an incomplete, unused EXIF subdirectory footer as the end of the directory chain, preserve the parsed fields, and record a format-compliance comment. Strict parsing, root-directory parsing, and BigTIFF retain their existing behavior; general I/O exceptions are not suppressed.
Regression coverage includes the reported 731 x 727 JPEG, preservation of EXIF entries, strict rejection, a complete footer, truncated root rejection, one to three remaining footer bytes, and big-endian EXIF data.
Issue: https://issues.apache.org/jira/browse/IMAGING-240
Validation: default
mvncompleted successfully on OpenJDK 23.0.2 and Maven 3.9.16 at f767bcf. Tests run: 1,268; failures: 0; errors: 0; skipped: 7. The complete default build, including RAT, Checkstyle, SpotBugs, PMD, and Javadoc, passed.