Repository navigation
[IMAGING-383/384] Handle grayscale PNG ICC profiles - #567
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Also translate ICC conversion failures for malformed profiles into ImagingException (IMAGING-384). Synthetic PNG/ICC tests cover both behaviors. Generated-by: OpenAI Codex gpt-6-luna
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the existing Jira reports IMAGING-383 and IMAGING-384.
Changes
ImagingException, preserving the underlying cause.Validation
PngIccProfileTest: 2 tests passed.mvn): succeeded; 2,522 tests, 0 failures, 0 errors, 14 skipped. The Windows task checkout had CRLF endings where Checkstyle expects LF, so 715 tracked uniform-CRLF text files were normalized to LF only during the build and restored afterward. No line-ending changes are included in this PR.AI disclosure
This PR used OpenAI Codex (gpt-6-luna) to assist with the implementation and synthetic tests. Human operator: dajiaohuang. I reviewed the changes and test results before submission.