Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[IMAGING-371] Preserve GPSVersionID when reading GPS directories
GPSVersionID has tag 0x0000, but TiffReader currently skips all zero-tag fields, including those in GPS directories. This loses the version field during metadata reading.
Allow tag zero in GPS directories while retaining the existing early filter elsewhere. Existing field-type and offset/length validation still applies.
Regression tests use generated classic TIFF inputs and cover both byte orders, strict and non-strict reading, the public metadata API, exact version bytes, adjacent entries, non-GPS zero tags, invalid GPS counts/offsets, and unknown GPS field types.
Issue: https://issues.apache.org/jira/browse/IMAGING-371
Validation: default
mvnpassed on the final two-commit branch with OpenJDK 23.0.2 and Maven 3.9.16: 1,277 tests, zero failures, zero errors, seven skipped. Javadoc and the default quality checks passed.