Skip to content

Fix MethodUtils.invokeMethod on instances of non-public classes - #1783

Open
lenamonj wants to merge 1 commit into
apache:masterfrom
lenamonj:reflect-accessible-fast-path
Open

Fix MethodUtils.invokeMethod on instances of non-public classes#1783
lenamonj wants to merge 1 commit into
apache:masterfrom
lenamonj:reflect-accessible-fast-path

Conversation

@lenamonj

@lenamonj lenamonj commented Sep 7, 2026

Copy link
Copy Markdown

getMatchingAccessibleMethod has an exact-signature fast path, added in #1427, that returns the Method declared on the receiver's own class without the accessible-declaration lookup the search path does. When that class is not public, which is every JDK collection factory result (Collections.emptyList(), Arrays.asList(), Collections.emptyMap()), invokeMethod throws IllegalAccessException although a public declaration exists on the interface.

The fast path now re-resolves the hit through getAccessibleMethod and keeps the original only when no public declaration exists, so a package-private class that setAccessible can open behaves as before.

Tests: four in MethodUtilsTest, red on master (three failures, one error) and green with the change. Default Maven goal green.

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude (Anthropic) found the defect and drafted the fix and tests; I reviewed them, reproduced the failure on a fresh clone of master, and ran the default Maven goal.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant