Fix MethodUtils.invokeMethod on instances of non-public classes - #1783
Open
lenamonj wants to merge 1 commit into
Open
Fix MethodUtils.invokeMethod on instances of non-public classes#1783lenamonj wants to merge 1 commit into
lenamonj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getMatchingAccessibleMethodhas an exact-signature fast path, added in #1427, that returns theMethoddeclared on the receiver's own class without the accessible-declaration lookup the search path does. When that class is not public, which is every JDK collection factory result (Collections.emptyList(),Arrays.asList(),Collections.emptyMap()),invokeMethodthrowsIllegalAccessExceptionalthough a public declaration exists on the interface.The fast path now re-resolves the hit through
getAccessibleMethodand keeps the original only when no public declaration exists, so a package-private class thatsetAccessiblecan open behaves as before.Tests: four in
MethodUtilsTest, red on master (three failures, one error) and green with the change. Default Maven goal green.mvn; that'smvnon the command line by itself.